From: Johannes Berg <johannes@sipsolutions.net>
To: Serge Belyshev <belyshev@depni.sinp.msu.ru>
Cc: Vadim Zaliva <lord@crocodile.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 1/1] integer overflow issue in 'appletouch' driver
Date: Sat, 07 Aug 2010 17:47:30 +0200 [thread overview]
Message-ID: <1281196050.4431.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <87k4o234lx.fsf@depni.sinp.msu.ru>
On Sat, 2010-08-07 at 14:00 +0000, Serge Belyshev wrote:
> Hi!
>
> Since 2.6.34 the touchpad on my feb 2005 powerbook (mod. A1106) has
> stopped working. I've identified the following guilty patch:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=04b4b88cca0ebe3813b4b6f014fb6a0db380b137
>
> > ... Testing on one of such PowerBooks I have
> > noticed that touchpad always generates positive values, but some of
> > them are greater that 127, and thus, when cast to 'signed char' being
> > interpreted as a negative.
>
> My device is 05ac:020e "fountain", actually generates *signed* values,
> thus the patch completely breaks it.
I think Ben might have the same issue. I guess we need per-touchpad
functions to read the data.
johannes
next prev parent reply other threads:[~2010-08-07 15:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 19:47 [PATCH 1/1] integer overflow issue in 'appletouch' driver Vadim Zaliva
2010-03-08 7:41 ` Johannes Berg
2010-03-09 19:43 ` Vadim Zaliva
2010-03-10 6:22 ` Dmitry Torokhov
2010-08-07 14:00 ` Serge Belyshev
2010-08-07 15:47 ` Johannes Berg [this message]
2010-08-09 0:20 ` Benjamin Herrenschmidt
2010-08-09 1:24 ` Vadim Zaliva
2010-08-09 3:43 ` Benjamin Herrenschmidt
2010-08-09 16:33 ` Dmitry Torokhov
2010-08-09 22:36 ` Benjamin Herrenschmidt
2018-06-20 0:24 ` Dmitry Torokhov
2010-03-10 17:37 ` Vadim Zaliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281196050.4431.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=belyshev@depni.sinp.msu.ru \
--cc=benh@kernel.crashing.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lord@crocodile.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).