From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Vadim Zaliva <lord@crocodile.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Serge Belyshev <belyshev@depni.sinp.msu.ru>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] integer overflow issue in 'appletouch' driver
Date: Mon, 09 Aug 2010 13:43:09 +1000 [thread overview]
Message-ID: <1281325390.2168.64.camel@pasglop> (raw)
In-Reply-To: <9D74DA20-E3C8-43BC-B529-82605F64637F@crocodile.org>
On Sun, 2010-08-08 at 18:24 -0700, Vadim Zaliva wrote:
> I have tested the patch on device I had
> I will have an access to it to retest later thus week. We can wait for my
> test to try to identify how my PowerBook is different from yours. Or you
> can roll the patch back.
I'd rather roll the patch back for now. I'll send the revert as part of
the next powerpc update. We'll sort things out then.
Cheers,
Ben.
>
> --
> Sent from my iPhone
>
> On Aug 8, 2010, at 17:20, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> >
> >>> My device is 05ac:020e "fountain", actually generates *signed* values,
> >>> thus the patch completely breaks it.
> >>
> >> I think Ben might have the same issue. I guess we need per-touchpad
> >> functions to read the data.
> >
> > Yup, I confirm, same deal. This patch completely breaks it on my
> > powerbook (same USB ID)
> >
> > Should we revert the commit for now ?
> >
> > Cheers,
> > Ben.
> >
next prev parent reply other threads:[~2010-08-09 3:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 19:47 [PATCH 1/1] integer overflow issue in 'appletouch' driver Vadim Zaliva
2010-03-08 7:41 ` Johannes Berg
2010-03-09 19:43 ` Vadim Zaliva
2010-03-10 6:22 ` Dmitry Torokhov
2010-08-07 14:00 ` Serge Belyshev
2010-08-07 15:47 ` Johannes Berg
2010-08-09 0:20 ` Benjamin Herrenschmidt
2010-08-09 1:24 ` Vadim Zaliva
2010-08-09 3:43 ` Benjamin Herrenschmidt [this message]
2010-08-09 16:33 ` Dmitry Torokhov
2010-08-09 22:36 ` Benjamin Herrenschmidt
2018-06-20 0:24 ` Dmitry Torokhov
2010-03-10 17:37 ` Vadim Zaliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281325390.2168.64.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=belyshev@depni.sinp.msu.ru \
--cc=dmitry.torokhov@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lord@crocodile.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).