From: Jason Wessel <jason.wessel@windriver.com>
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org,
kgdb-bugreport@lists.sourceforge.net,
Jason Wessel <jason.wessel@windriver.com>,
Dipankar Sarma <dipankar@in.ibm.com>, Ingo Molnar <mingo@elte.hu>
Subject: [RFC PATCH 2/2] rcu,debug_core: allow the kernel debugger to reset the rcu stall timer
Date: Mon, 9 Aug 2010 00:12:12 -0500 [thread overview]
Message-ID: <1281330732-17164-3-git-send-email-jason.wessel@windriver.com> (raw)
In-Reply-To: <1281330732-17164-2-git-send-email-jason.wessel@windriver.com>
When returning from the kernel debugger allow a reset of the rcu
jiffies_stall value to prevent the rcu stall detector from sending NMI
events which stack dumps on all the cpus in the system.
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
CC: Dipankar Sarma <dipankar@in.ibm.com>
CC: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
CC: Ingo Molnar <mingo@elte.hu>
---
include/linux/rcupdate.h | 8 ++++++++
kernel/debug/debug_core.c | 2 ++
kernel/rcutree.c | 9 +++++++++
3 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
index 9fbc54a..abd3ab6 100644
--- a/include/linux/rcupdate.h
+++ b/include/linux/rcupdate.h
@@ -599,4 +599,12 @@ static inline void debug_rcu_head_unqueue(struct rcu_head *head)
#define rcu_dereference_index_check(p, c) \
__rcu_dereference_index_check((p), (c))
+#ifdef CONFIG_RCU_CPU_STALL_DETECTOR
+extern void rcu_cpu_stall_reset(void);
+#else /* #ifdef CONFIG_RCU_CPU_STALL_DETECTOR */
+static inline void rcu_cpu_stall_reset(void)
+{
+}
+#endif /* #ifdef CONFIG_RCU_CPU_STALL_DETECTOR */
+
#endif /* __LINUX_RCUPDATE_H */
diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
index e4d6819..1600e90 100644
--- a/kernel/debug/debug_core.c
+++ b/kernel/debug/debug_core.c
@@ -47,6 +47,7 @@
#include <linux/pid.h>
#include <linux/smp.h>
#include <linux/mm.h>
+#include <linux/rcupdate.h>
#include <asm/cacheflush.h>
#include <asm/byteorder.h>
@@ -474,6 +475,7 @@ static void dbg_touch_watchdogs(void)
{
touch_softlockup_watchdog_sync();
clocksource_touch_watchdog();
+ rcu_cpu_stall_reset();
}
static int kgdb_cpu_enter(struct kgdb_state *ks, struct pt_regs *regs)
diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index d5bc439..209b755 100644
--- a/kernel/rcutree.c
+++ b/kernel/rcutree.c
@@ -532,6 +532,9 @@ static void check_cpu_stall(struct rcu_state *rsp, struct rcu_data *rdp)
if (rcu_cpu_stall_panicking)
return;
+ /* Gracefully handle a watch dog reset when jiffies_stall == 0 */
+ if (!rsp->jiffies_stall)
+ return;
delta = jiffies - rsp->jiffies_stall;
rnp = rdp->mynode;
if ((rnp->qsmask & rdp->grpmask) && delta >= 0) {
@@ -561,6 +564,12 @@ static void __init check_cpu_stall_init(void)
atomic_notifier_chain_register(&panic_notifier_list, &rcu_panic_block);
}
+void rcu_cpu_stall_reset(void)
+{
+ rcu_sched_state.jiffies_stall = 0;
+ rcu_bh_state.jiffies_stall = 0;
+}
+
#else /* #ifdef CONFIG_RCU_CPU_STALL_DETECTOR */
static void record_gp_stall_check_time(struct rcu_state *rsp)
--
1.6.3.3
next prev parent reply other threads:[~2010-08-09 5:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 5:12 [RFC PATCH 0/2] RCU stall handler for kernel debugger Jason Wessel
2010-08-09 5:12 ` [RFC PATCH 1/2] debug_core: move all watch dog syncs to a single function Jason Wessel
2010-08-09 5:12 ` Jason Wessel [this message]
2010-08-09 17:43 ` [RFC PATCH 2/2] rcu,debug_core: allow the kernel debugger to reset the rcu stall timer Paul E. McKenney
2010-08-09 18:26 ` Jason Wessel
2010-08-09 19:01 ` Paul E. McKenney
2010-08-11 4:01 ` Paul E. McKenney
2010-08-11 14:07 ` Jason Wessel
2010-08-11 16:32 ` Paul E. McKenney
2018-06-19 21:18 ` Paul E. McKenney
2018-06-20 9:55 ` [Kgdb-bugreport] [RFC PATCH 1/2] debug_core: move all watch dog syncs to a single function Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281330732-17164-3-git-send-email-jason.wessel@windriver.com \
--to=jason.wessel@windriver.com \
--cc=dipankar@in.ibm.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).