From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Anuj Aggarwal <anuj.aggarwal@ti.com>
Subject: [PATCH RESEND] regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe
Date: Mon, 09 Aug 2010 15:51:23 +0800 [thread overview]
Message-ID: <1281340283.20518.1.camel@mola> (raw)
We should call platform_set_drvdata() before calling platform_get_drvdata().
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
Per Mark's comment, this resend remove platform_set_drvdata(pdev, NULL)
in tps6507x_pmic_remove.
drivers/regulator/tps6507x-regulator.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x-regulator.c
index 8152d65..c239f42 100644
--- a/drivers/regulator/tps6507x-regulator.c
+++ b/drivers/regulator/tps6507x-regulator.c
@@ -614,6 +614,7 @@ int tps6507x_pmic_probe(struct platform_device *pdev)
}
tps6507x_dev->pmic = tps;
+ platform_set_drvdata(pdev, tps6507x_dev);
return 0;
--
1.5.4.3
next reply other threads:[~2010-08-09 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 7:51 Axel Lin [this message]
2010-08-10 14:46 ` [PATCH RESEND] regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe Mark Brown
2010-08-10 17:18 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281340283.20518.1.camel@mola \
--to=axel.lin@gmail.com \
--cc=anuj.aggarwal@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).