* [PATCH RESEND] regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe
@ 2010-08-09 7:51 Axel Lin
2010-08-10 14:46 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2010-08-09 7:51 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown, Anuj Aggarwal
We should call platform_set_drvdata() before calling platform_get_drvdata().
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
Per Mark's comment, this resend remove platform_set_drvdata(pdev, NULL)
in tps6507x_pmic_remove.
drivers/regulator/tps6507x-regulator.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x-regulator.c
index 8152d65..c239f42 100644
--- a/drivers/regulator/tps6507x-regulator.c
+++ b/drivers/regulator/tps6507x-regulator.c
@@ -614,6 +614,7 @@ int tps6507x_pmic_probe(struct platform_device *pdev)
}
tps6507x_dev->pmic = tps;
+ platform_set_drvdata(pdev, tps6507x_dev);
return 0;
--
1.5.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe
2010-08-09 7:51 [PATCH RESEND] regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe Axel Lin
@ 2010-08-10 14:46 ` Mark Brown
2010-08-10 17:18 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2010-08-10 14:46 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Liam Girdwood, Anuj Aggarwal
On Mon, Aug 09, 2010 at 03:51:23PM +0800, Axel Lin wrote:
> We should call platform_set_drvdata() before calling platform_get_drvdata().
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe
2010-08-10 14:46 ` Mark Brown
@ 2010-08-10 17:18 ` Liam Girdwood
0 siblings, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-08-10 17:18 UTC (permalink / raw)
To: Mark Brown; +Cc: Axel Lin, linux-kernel, Anuj Aggarwal
On Tue, 2010-08-10 at 15:46 +0100, Mark Brown wrote:
> On Mon, Aug 09, 2010 at 03:51:23PM +0800, Axel Lin wrote:
> > We should call platform_set_drvdata() before calling platform_get_drvdata().
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> --
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-10 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-09 7:51 [PATCH RESEND] regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe Axel Lin
2010-08-10 14:46 ` Mark Brown
2010-08-10 17:18 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).