* [PATCH] regulator: tps6586x - add regulator_unregister() in tps6586x_regulator_remove()
@ 2010-08-09 7:58 Axel Lin
2010-08-10 15:00 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Axel Lin @ 2010-08-09 7:58 UTC (permalink / raw)
To: linux-kernel; +Cc: Mike Rapoport, Mark Brown, Liam Girdwood
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/tps6586x-regulator.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/tps6586x-regulator.c b/drivers/regulator/tps6586x-regulator.c
index 3c2eee8..122193b 100644
--- a/drivers/regulator/tps6586x-regulator.c
+++ b/drivers/regulator/tps6586x-regulator.c
@@ -357,13 +357,16 @@ static int __devinit tps6586x_regulator_probe(struct platform_device *pdev)
return PTR_ERR(rdev);
}
- platform_set_drvdata(pdev, ri);
+ platform_set_drvdata(pdev, rdev);
return 0;
}
static int __devexit tps6586x_regulator_remove(struct platform_device *pdev)
{
+ struct regulator_dev *rdev = platform_get_drvdata(pdev);
+
+ regulator_unregister(rdev);
return 0;
}
--
1.5.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: tps6586x - add regulator_unregister() in tps6586x_regulator_remove()
2010-08-09 7:58 [PATCH] regulator: tps6586x - add regulator_unregister() in tps6586x_regulator_remove() Axel Lin
@ 2010-08-10 15:00 ` Mark Brown
2010-08-10 15:32 ` Mike Rapoport
2010-08-10 17:18 ` Liam Girdwood
0 siblings, 2 replies; 4+ messages in thread
From: Mark Brown @ 2010-08-10 15:00 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Mike Rapoport, Liam Girdwood
On Mon, Aug 09, 2010 at 03:58:06PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> - platform_set_drvdata(pdev, ri);
> + platform_set_drvdata(pdev, rdev);
>
This would've been easier to review if you'd mentioned in the changelog
that there were no users of the current platform data, just to show that
you'd checked.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: tps6586x - add regulator_unregister() in tps6586x_regulator_remove()
2010-08-10 15:00 ` Mark Brown
@ 2010-08-10 15:32 ` Mike Rapoport
2010-08-10 17:18 ` Liam Girdwood
1 sibling, 0 replies; 4+ messages in thread
From: Mike Rapoport @ 2010-08-10 15:32 UTC (permalink / raw)
To: Mark Brown; +Cc: Axel Lin, linux-kernel, Liam Girdwood
Mark Brown wrote:
> On Mon, Aug 09, 2010 at 03:58:06PM +0800, Axel Lin wrote:
>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Mike Rapoport <mike@compulab.co.il>
>
>>
>> - platform_set_drvdata(pdev, ri);
>> + platform_set_drvdata(pdev, rdev);
>>
>
> This would've been easier to review if you'd mentioned in the changelog
> that there were no users of the current platform data, just to show that
> you'd checked.
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: tps6586x - add regulator_unregister() in tps6586x_regulator_remove()
2010-08-10 15:00 ` Mark Brown
2010-08-10 15:32 ` Mike Rapoport
@ 2010-08-10 17:18 ` Liam Girdwood
1 sibling, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2010-08-10 17:18 UTC (permalink / raw)
To: Mark Brown; +Cc: Axel Lin, linux-kernel, Mike Rapoport
On Tue, 2010-08-10 at 16:00 +0100, Mark Brown wrote:
> On Mon, Aug 09, 2010 at 03:58:06PM +0800, Axel Lin wrote:
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-10 17:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-09 7:58 [PATCH] regulator: tps6586x - add regulator_unregister() in tps6586x_regulator_remove() Axel Lin
2010-08-10 15:00 ` Mark Brown
2010-08-10 15:32 ` Mike Rapoport
2010-08-10 17:18 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).