From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756323Ab0HJDH0 (ORCPT ); Mon, 9 Aug 2010 23:07:26 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:61548 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755493Ab0HJDHT (ORCPT ); Mon, 9 Aug 2010 23:07:19 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=u0mUZfVKMfjQMCMlTQUtYrZnrXYF7+g6iTLdj7fENDi8QUvJIZIHD9qS/VJKVrI3OI 4sbW3B9PahnkpHw2Y+/0DyD2tLfDc+3JMQUT9c8x8rbOHy1uXM5dNb+un0WVqAmAeNT+ dUMwzEhqY78u7y8p0BsBtRUJGA+HqBEIwiP1Y= Subject: Re: [PATCH] MIPS: remove RELOC_HIDE on __pa_symbol From: Namhyung Kim To: Ralf Baechle Cc: David Daney , linux-kernel@vger.kernel.org, David Daney , linux-mips@linux-mips.org In-Reply-To: <20100809122147.GA23053@linux-mips.org> References: <1281297456-2711-1-git-send-email-namhyung@gmail.com> <4C5F8ED8.90301@gmail.com> <20100809122147.GA23053@linux-mips.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 10 Aug 2010 12:07:08 +0900 Message-ID: <1281409628.1670.11.camel@leonhard> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2010-08-09 (월), 13:21 +0100, Ralf Baechle: > On Sun, Aug 08, 2010 at 10:15:04PM -0700, David Daney wrote: > > Maybe you could explain in more detail the problems you are having > > with the current definition of __pa_symbol(). I would be hesitant > > to change this bit of black magic unless there is a concrete problem > > you are trying to solve. > > RELOC_HIDE was originally added by 6007b903dfe5f1d13e0c711ac2894bdd4a61b1ad > (lmo) rsp. 8431fd094d625b94d364fe393076ccef88e6ce18 (kernel.org). A > discussion can be found in lkml posting > a2ebde260608230500o3407b108hc03debb9da6e62c@mail.gmail.com> which is > archived at > > http://lists.linuxcoding.com/kernel/2006-q3/msg17360.html > > I felt this was dubious by the time it was added and probably should go? > > Ralf Hi, I've sent basically same patch to x86 folks [1] and they said there is a possiblility of miscompilation on gcc 3. I am not sure the same goes here on mips but it might be safer to keep it. Sorry for the noise ;-( [1] http://lkml.org/lkml/2010/8/8/138 -- Regards, Namhyung Kim