public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Alan Cox <alan@linux.intel.com>, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 29/68] tty: Move the vt_tty field from the vc_data into the standard tty_port
Date: Tue, 10 Aug 2010 14:58:51 -0700	[thread overview]
Message-ID: <1281477570-18944-29-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20100810214425.GB17385@kroah.com>

From: Alan Cox <alan@linux.intel.com>

This takes all the tty references through the expected interface points so
we can refcount them.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/char/keyboard.c        |   10 +++++-----
 drivers/char/vt.c              |   10 +++++-----
 drivers/char/vt_ioctl.c        |    2 +-
 include/linux/console_struct.h |    1 -
 4 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c
index 25be210..a7ca752 100644
--- a/drivers/char/keyboard.c
+++ b/drivers/char/keyboard.c
@@ -299,7 +299,7 @@ int kbd_rate(struct kbd_repeat *rep)
  */
 static void put_queue(struct vc_data *vc, int ch)
 {
-	struct tty_struct *tty = vc->vc_tty;
+	struct tty_struct *tty = vc->port.tty;
 
 	if (tty) {
 		tty_insert_flip_char(tty, ch, 0);
@@ -309,7 +309,7 @@ static void put_queue(struct vc_data *vc, int ch)
 
 static void puts_queue(struct vc_data *vc, char *cp)
 {
-	struct tty_struct *tty = vc->vc_tty;
+	struct tty_struct *tty = vc->port.tty;
 
 	if (!tty)
 		return;
@@ -485,7 +485,7 @@ static void fn_show_ptregs(struct vc_data *vc)
 
 static void fn_hold(struct vc_data *vc)
 {
-	struct tty_struct *tty = vc->vc_tty;
+	struct tty_struct *tty = vc->port.tty;
 
 	if (rep || !tty)
 		return;
@@ -563,7 +563,7 @@ static void fn_inc_console(struct vc_data *vc)
 
 static void fn_send_intr(struct vc_data *vc)
 {
-	struct tty_struct *tty = vc->vc_tty;
+	struct tty_struct *tty = vc->port.tty;
 
 	if (!tty)
 		return;
@@ -1162,7 +1162,7 @@ static void kbd_keycode(unsigned int keycode, int down, int hw_raw)
 	struct keyboard_notifier_param param = { .vc = vc, .value = keycode, .down = down };
 	int rc;
 
-	tty = vc->vc_tty;
+	tty = vc->port.tty;
 
 	if (tty && (!tty->driver_data)) {
 		/* No driver data? Strange. Okay we fix it then. */
diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index 295af82..c734f9b 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -973,12 +973,12 @@ static int vc_do_resize(struct tty_struct *tty, struct vc_data *vc,
  *	Resize a virtual console as seen from the console end of things. We
  *	use the common vc_do_resize methods to update the structures. The
  *	caller must hold the console sem to protect console internals and
- *	vc->vc_tty
+ *	vc->port.tty
  */
 
 int vc_resize(struct vc_data *vc, unsigned int cols, unsigned int rows)
 {
-	return vc_do_resize(vc->vc_tty, vc, cols, rows);
+	return vc_do_resize(vc->port.tty, vc, cols, rows);
 }
 
 /**
@@ -2807,12 +2807,12 @@ static int con_open(struct tty_struct *tty, struct file *filp)
 			struct vc_data *vc = vc_cons[currcons].d;
 
 			/* Still being freed */
-			if (vc->vc_tty) {
+			if (vc->port.tty) {
 				release_console_sem();
 				return -ERESTARTSYS;
 			}
 			tty->driver_data = vc;
-			vc->vc_tty = tty;
+			vc->port.tty = tty;
 
 			if (!tty->winsize.ws_row && !tty->winsize.ws_col) {
 				tty->winsize.ws_row = vc_cons[currcons].d->vc_rows;
@@ -2840,7 +2840,7 @@ static void con_shutdown(struct tty_struct *tty)
 	struct vc_data *vc = tty->driver_data;
 	BUG_ON(vc == NULL);
 	acquire_console_sem();
-	vc->vc_tty = NULL;
+	vc->port.tty = NULL;
 	release_console_sem();
 	tty_shutdown(tty);
 }
diff --git a/drivers/char/vt_ioctl.c b/drivers/char/vt_ioctl.c
index cb19dbc..72dcfb2 100644
--- a/drivers/char/vt_ioctl.c
+++ b/drivers/char/vt_ioctl.c
@@ -1369,7 +1369,7 @@ void vc_SAK(struct work_struct *work)
 	acquire_console_sem();
 	vc = vc_con->d;
 	if (vc) {
-		tty = vc->vc_tty;
+		tty = vc->port.tty;
 		/*
 		 * SAK should also work in all raw modes and reset
 		 * them properly.
diff --git a/include/linux/console_struct.h b/include/linux/console_struct.h
index 25bf67f..7f0c329 100644
--- a/include/linux/console_struct.h
+++ b/include/linux/console_struct.h
@@ -58,7 +58,6 @@ struct vc_data {
 	/* VT terminal data */
 	unsigned int	vc_state;		/* Escape sequence parser state */
 	unsigned int	vc_npar,vc_par[NPAR];	/* Parameters of current escape sequence */
-	struct tty_struct *vc_tty;		/* TTY we are attached to */
 	/* data for manual vt switching */
 	struct vt_mode	vt_mode;
 	struct pid 	*vt_pid;
-- 
1.7.2


  parent reply	other threads:[~2010-08-10 22:00 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-10 21:44 [GIT PATCH] TTY patches for 2.6.36, try 2 Greg KH
2010-08-10 21:58 ` [PATCH 01/68] n_gsm.c: removed duplicated #includes Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 02/68] serial: There's no config CONSOLE Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 03/68] vt: clean up the code - use kernel library Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 04/68] serial: add UART_CAP_EFR and UART_CAP_SLEEP flags to 16C950 UARTs definition Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 05/68] mrst_max3110: add UART driver for Max3110 on Moorestown Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 06/68] max3110 sanity check a register Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 07/68] serial: replace open coded mutex with a real mutex in mrst_max3110.c Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 08/68] serial: fix wakup races in the mrst_max3110 driver Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 09/68] tty: Remove Hayes ESP ioctls Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 10/68] tty: remove remaining " Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 11/68] tty: Add EXTPROC support for LINEMODE Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 12/68] vt/console: try harder to print output when panicing Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 13/68] stallion: prune lock_kernel calls Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 14/68] istallion: use bit ops for the board flags Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 15/68] riscom8: kill use of lock_kernel Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 16/68] isicom: kill off the BKL Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 17/68] rocket: kill BKL Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 18/68] synclink: kill the big kernel lock Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 19/68] cyclades: Kill off BKL usage Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 20/68] epca: Kill the big kernel lock Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 21/68] specialix: Kill the BKL Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 22/68] tty: Fix the digi acceleport driver NULL checks Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 23/68] synclink: reworking locking a bit Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 24/68] tty: serial - fix various misuses/mishandlings of port->tty Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 25/68] tty: serial - fix tty back references in termios Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 26/68] tty: serial - fix tty referencing in set_ldisc Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 27/68] vc: Locking clean up Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 28/68] tty: Make vt's have a tty_port Greg Kroah-Hartman
2010-08-10 21:58 ` Greg Kroah-Hartman [this message]
2010-08-10 21:58 ` [PATCH 30/68] serial: Change the wait for carrier locking Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 31/68] serial: add port helpers Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 32/68] serial: trim locking on the helpers Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 33/68] serial: Use block_til_ready helper Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 34/68] serial: fix termios settings in open Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 35/68] tty: replace BKL with a new tty_lock Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 36/68] tty: never hold BTM while getting tty_mutex Greg Kroah-Hartman
2010-08-10 21:58 ` [PATCH 37/68] tty: fix console_sem lock order Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 38/68] cdc-acm: remove dead code Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 39/68] tty: introduce wait_event_interruptible_tty Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 40/68] tty: reorder ldisc locking Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 41/68] tty: untangle locking of wait_until_sent Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 42/68] tty: remove tty_lock_nested Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 43/68] tty: implement BTM as mutex instead of BKL Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 44/68] tty: release BTM while sleeping in block_til_ready Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 45/68] 8250: fix set_ldisc operation Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 46/68] tty: avoid recursive BTM in pty_close Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 47/68] serial: max3107: introduce a max3107 driver Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 48/68] serial: max3107: Abstract out the platform specific bits Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 49/68] tty_io: remove casts from void* Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 50/68] vt: Fix warning: statement with no effect due to vt_kern.h Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 51/68] serial: crisv10: formatting of pointers in printk() Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 52/68] serial: "altera_uart: simplify altera_uart_console_putc()" checkpatch fixes Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 53/68] serial: fix missing bit coverage of ASYNC_FLAGS Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 54/68] serial: general fixes in the serial_rs485 structure Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 55/68] serial: mcf: don't take spinlocks in already protected functions Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 56/68] serial: MMIO32 support for 8250_early.c Greg Kroah-Hartman
2010-08-12 18:43   ` Tony Luck
2010-08-12 18:46     ` Greg KH
2010-08-12 19:16       ` [PATCH] print early console device address in hex Luck, Tony
2010-08-10 21:59 ` [PATCH 57/68] timbuart: use __devinit and __devexit macros for probe and remove Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 58/68] serial: 68328serial.c: remove dead (ALMA_ANS | DRAGONIXVZ | M68EZ328ADS) Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 59/68] serial: add support for OX16PCI958 card Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 60/68] mxser: remove unnesesary NULL check Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 61/68] hsu: driver for Medfield High Speed UART device Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 62/68] hsu: add a periodic timer to check dma rx channel Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 63/68] hsu: some code cleanup Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 64/68] hsu: call PCI pm hooks in suspend/resume function Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 65/68] serial: max3107: Fix gpiolib support Greg Kroah-Hartman
2010-08-10 21:59 ` [PATCH 68/68] U6715 16550A serial driver support Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281477570-18944-29-git-send-email-gregkh@suse.de \
    --to=gregkh@suse.de \
    --cc=alan@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox