From: Namhyung Kim <namhyung@gmail.com>
To: Ma Ling <ling.ma@intel.com>
Cc: hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org,
mingo@elte.hu
Subject: Re: [PATCH V2] [X86] Fix potential issue on memmove
Date: Thu, 12 Aug 2010 15:48:35 +0900 [thread overview]
Message-ID: <1281595715.1631.5.camel@leonhard> (raw)
> --- a/arch/x86/lib/memcpy_32.c
> +++ b/arch/x86/lib/memcpy_32.c
> @@ -25,19 +25,35 @@ void *memmove(void *dest, const void *src, size_t n)
> int d0, d1, d2;
>
> if (dest < src) {
> - memcpy(dest, src, n);
> + if ((dest + n) < src)
> + return memcpy(dest, src, n);
> + else
> + __asm__ __volatile__(
> + "rep\n\t"
> + "movsb\n\t"
> + : "=&c" (d0), "=&S" (d1), "=&D" (d2)
> + :"0" (n),
> + "1" (src),
> + "2" (dest)
> + :"memory");
> +
> } else {
> - __asm__ __volatile__(
> - "std\n\t"
> - "rep\n\t"
> - "movsb\n\t"
> - "cld"
> - : "=&c" (d0), "=&S" (d1), "=&D" (d2)
> - :"0" (n),
> - "1" (n-1+src),
> - "2" (n-1+dest)
> - :"memory");
> + if((src + count) < dest)
> + return memcpy(dest, src, count);
'count' should be 'n'.
--
Regards,
Namhyung Kim
next reply other threads:[~2010-08-12 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 6:48 Namhyung Kim [this message]
2010-08-12 6:52 ` [PATCH V2] [X86] Fix potential issue on memmove Ma, Ling
2010-08-12 14:15 ` H. Peter Anvin
2010-08-12 14:22 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2010-08-11 22:20 ling.ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281595715.1631.5.camel@leonhard \
--to=namhyung@gmail.com \
--cc=hpa@zytor.com \
--cc=ling.ma@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).