From: Joe Perches <joe@perches.com>
To: kxie@chelsio.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
open-iscsi@googlegroups.com, rranjan@chelsio.com,
James.Bottomley@HansenPartnership.com, michaelc@cs.wisc.edu
Subject: Re: [PATCH v2 1/3] libcxgbi: common library for cxgb3i and cxgb4i
Date: Thu, 12 Aug 2010 20:21:40 -0700 [thread overview]
Message-ID: <1281669700.15486.71.camel@Joe-Laptop> (raw)
In-Reply-To: <201008130257.o7D2vLVx001282@localhost.localdomain>
On Thu, 2010-08-12 at 19:57 -0700, kxie@chelsio.com wrote:
> [PATCH v2 1/3] libcxgbi: common library for cxgb3i and cxgb4i
[]
> +#define libcxgbi_log_error cxgbi_dbg_error
> +#define libcxgbi_log_warn cxgbi_dbg_warn
> +#define libcxgbi_log_info cxgbi_dbg_info
> +#define libcxgbi_log_debug(flag, fmt, args...) \
> + cxgbi_dbg_print(flag, fmt, ## args)
I think this double indirection isn't useful and it would
be simpler/better to use pr_<level>
[]
> +#define cxgbi_dbg_print(level, fmt, args...) \
> + do { \
> + if (dbg_level & (level)) \
> + printk(KERN_INFO "cxgbi: %s - " fmt, \
> + __func__ , ## args); \
> + } while (0)
> +#define cxgbi_dbg_error(fmt, args...) \
> + printk(KERN_ERR "cxgbi: ERR! %s, " fmt, __func__ , ## args)
> +#define cxgbi_dbg_warn(fmt, args...) \
> + printk(KERN_WARNING "cxgbi: WARN! %s, " fmt, __func__ , ## args)
> +#define cxgbi_dbg_info(fmt, args...) \
> + printk(KERN_INFO "cxgbi: %s, " fmt, __func__ , ## args)
next prev parent reply other threads:[~2010-08-13 3:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 2:57 [PATCH v2 1/3] libcxgbi: common library for cxgb3i and cxgb4i kxie
2010-08-13 3:21 ` Joe Perches [this message]
2010-08-13 3:44 ` Karen Xie
2010-08-16 16:48 ` Joe Perches
2010-08-17 0:02 ` Karen Xie
2010-08-17 0:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281669700.15486.71.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=kxie@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=open-iscsi@googlegroups.com \
--cc=rranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox