* [PATCH] staging/comedi das08_cs.c: Fix io_req_t conversion
@ 2010-08-14 1:24 Andreas Bombe
2010-08-14 8:32 ` Dominik Brodowski
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Bombe @ 2010-08-14 1:24 UTC (permalink / raw)
To: linux-kernel; +Cc: Dominik Brodowski, Greg Kroah-Hartman, devel, Andreas Bombe
Commit 90abdc3b9 converted all PCMCIA users away from io_req_t. In
das08_cs.c the converted IO lines mask setting was added but the old
line using the now inexistent p_dev->io was not removed.
Signed-off-by: Andreas Bombe <aeb@debian.org>
---
drivers/staging/comedi/drivers/das08_cs.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08_cs.c b/drivers/staging/comedi/drivers/das08_cs.c
index c6aa52f..48d9fb1 100644
--- a/drivers/staging/comedi/drivers/das08_cs.c
+++ b/drivers/staging/comedi/drivers/das08_cs.c
@@ -222,7 +222,6 @@ static int das08_pcmcia_config_loop(struct pcmcia_device *p_dev,
p_dev->resource[0]->flags &= ~IO_DATA_PATH_WIDTH;
p_dev->resource[0]->flags |=
pcmcia_io_cfg_data_width(io->flags);
- p_dev->io.IOAddrLines = io->flags & CISTPL_IO_LINES_MASK;
p_dev->resource[0]->start = io->win[0].base;
p_dev->resource[0]->end = io->win[0].len;
if (io->nwin > 1) {
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging/comedi das08_cs.c: Fix io_req_t conversion
2010-08-14 1:24 [PATCH] staging/comedi das08_cs.c: Fix io_req_t conversion Andreas Bombe
@ 2010-08-14 8:32 ` Dominik Brodowski
2010-08-14 13:49 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Dominik Brodowski @ 2010-08-14 8:32 UTC (permalink / raw)
To: Andreas Bombe, Greg Kroah-Hartman; +Cc: linux-kernel, devel
Thanks, Andreas.
Greg, do you have other -staging stuff pending to push to Linus? If so,
could you take it? Otherwise, I'll queue it up for my bugfixes branch.
On Sat, Aug 14, 2010 at 03:24:22AM +0200, Andreas Bombe wrote:
> Commit 90abdc3b9 converted all PCMCIA users away from io_req_t. In
> das08_cs.c the converted IO lines mask setting was added but the old
> line using the now inexistent p_dev->io was not removed.
>
> Signed-off-by: Andreas Bombe <aeb@debian.org>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Best,
Dominik
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging/comedi das08_cs.c: Fix io_req_t conversion
2010-08-14 8:32 ` Dominik Brodowski
@ 2010-08-14 13:49 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2010-08-14 13:49 UTC (permalink / raw)
To: Dominik Brodowski, Andreas Bombe, linux-kernel, devel
On Sat, Aug 14, 2010 at 10:32:12AM +0200, Dominik Brodowski wrote:
> Thanks, Andreas.
>
> Greg, do you have other -staging stuff pending to push to Linus? If so,
> could you take it? Otherwise, I'll queue it up for my bugfixes branch.
Yes I do, I can take this, thanks.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-14 13:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-14 1:24 [PATCH] staging/comedi das08_cs.c: Fix io_req_t conversion Andreas Bombe
2010-08-14 8:32 ` Dominik Brodowski
2010-08-14 13:49 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox