From: Peter Zijlstra <peterz@infradead.org>
To: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
Cc: Kusanagi Kouichi <slash@ac.auone-net.jp>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Don't use brace expansion.
Date: Mon, 16 Aug 2010 16:30:43 +0200 [thread overview]
Message-ID: <1281969043.1926.1469.camel@laptop> (raw)
In-Reply-To: <1281967761.17267.6.camel@thorin>
On Mon, 2010-08-16 at 16:09 +0200, Bernd Petrovitsch wrote:
> > -$(shell sh -c 'mkdir -p $(OUTPUT)scripts/{perl,python}/Perf-Trace-Util/' 2> /dev/null)
> > -$(shell sh -c 'mkdir -p $(OUTPUT)util/{ui/browsers,scripting-engines}/' 2> /dev/null)
> The other solution is to use standard-make features like in
> mkdir -p $(foreach d,ui/browsers scripting-engines,$(OUTPUT)util/$(d)/) 2> /dev/null
>
> Is there actually a specific reason for the
> $(shell sh -c '...')
> around?
> It looks superflous.
I think the reason is is that nobody who touched that file really knew
make all that well. Your version looks fine to me.
next prev parent reply other threads:[~2010-08-16 14:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 12:41 [PATCH] perf tools: Don't use brace expansion Kusanagi Kouichi
2010-08-16 13:30 ` Peter Zijlstra
2010-08-16 14:09 ` Bernd Petrovitsch
2010-08-16 14:30 ` Peter Zijlstra [this message]
2010-08-16 14:54 ` Bernd Petrovitsch
2010-08-16 15:29 ` Arnaldo Carvalho de Melo
2010-08-16 15:43 ` Bernd Petrovitsch
2010-08-16 15:50 ` Arnaldo Carvalho de Melo
2010-08-17 11:58 ` Bernd Petrovitsch
2010-08-17 15:42 ` Arnaldo Carvalho de Melo
2010-08-17 16:09 ` Bernd Petrovitsch
2010-08-17 18:16 ` Arnaldo Carvalho de Melo
2010-08-18 9:47 ` Bernd Petrovitsch
2010-08-18 8:18 ` [tip:perf/urgent] perf tools: Fix build on POSIX shells tip-bot for Bernd Petrovitsch
2010-08-16 15:24 ` [PATCH] perf tools: Don't use brace expansion Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281969043.1926.1469.camel@laptop \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=bernd@petrovitsch.priv.at \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=slash@ac.auone-net.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox