From: Peter Zijlstra <peterz@infradead.org>
To: Salman Qazi <sqazi@google.com>
Cc: paulmck@us.ibm.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, adurbin@google.com
Subject: Re: [PATCH] Fixed a mismatch between the users of radix_tree and the implementation.
Date: Mon, 16 Aug 2010 21:33:56 +0200 [thread overview]
Message-ID: <1281987236.1926.1895.camel@laptop> (raw)
In-Reply-To: <20100816182834.3541.42317.stgit@bumblebee1.mtv.corp.google.com>
On Mon, 2010-08-16 at 11:30 -0700, Salman Qazi wrote:
> For the delete case,
> we no longer shrink the tree back to being just the root containing the
> only remaining object. For the insert case, we no longer store the
> first object in the root, rather allocating a node structure for it. The
> reason that this works is that deleting (or inserting) intermediate nodes
> does not make a difference to a reader holding a slot.
Ah, I through that was what it did. So you basically increase the memory
footprint for tiny files.. have you done any measurements on that?
next prev parent reply other threads:[~2010-08-16 19:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 7:15 [PATCH] Fixed a mismatch between the users of radix_tree and the implementation Salman Qazi
2010-08-13 7:20 ` Salman Qazi
2010-08-16 11:25 ` Peter Zijlstra
2010-08-16 18:30 ` Salman Qazi
2010-08-16 19:33 ` Peter Zijlstra [this message]
[not found] ` <AANLkTindpUo5tPiXVp6wXjOAqczrJvYegrOMBqSjr4_t@mail.gmail.com>
2010-08-16 21:05 ` Salman Qazi
2010-08-16 21:06 ` Peter Zijlstra
2010-08-17 4:35 ` Salman Qazi
2010-08-17 4:45 ` Salman Qazi
2010-08-17 8:42 ` Peter Zijlstra
2010-08-17 15:23 ` Nick Piggin
2010-08-17 15:48 ` Peter Zijlstra
2010-08-17 19:49 ` Salman Qazi
2010-08-17 21:28 ` Salman Qazi
2010-08-30 23:27 ` Salman Qazi
2010-11-10 19:16 ` Salman Qazi
2010-11-11 0:29 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281987236.1926.1895.camel@laptop \
--to=peterz@infradead.org \
--cc=adurbin@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@us.ibm.com \
--cc=sqazi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox