From: Joe Perches <joe@perches.com>
To: Karen Xie <kxie@chelsio.com>
Cc: open-iscsi@googlegroups.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, Rakesh Ranjan <rakesh@chelsio.com>,
James.Bottomley@HansenPartnership.com, michaelc@cs.wisc.edu
Subject: RE: [PATCH v2 1/3] libcxgbi: common library for cxgb3i and cxgb4i
Date: Mon, 16 Aug 2010 17:22:37 -0700 [thread overview]
Message-ID: <1282004557.24541.2.camel@Joe-Laptop> (raw)
In-Reply-To: <8A71B368A89016469F72CD08050AD334084A2C95@maui.asicdesigners.com>
On Mon, 2010-08-16 at 17:02 -0700, Karen Xie wrote:
> Thanks, Joe.
>
> I will update the patch with your suggestion. BTW, I probably won't use
> pr_<level> just to avoid any confusion since they are already defined in
> kernel.h. I know I can undef them, but rather not to.
Hi Karen.
The point is to use pr_<level> precisely because it is
defined in kernel.h and they are standard kernel functions
commonly used in the rest of the kernel source.
There's no need to undef it any more than there is to
#undef printk or use a #define printf printk
cheers, Joe
prev parent reply other threads:[~2010-08-17 0:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 2:57 [PATCH v2 1/3] libcxgbi: common library for cxgb3i and cxgb4i kxie
2010-08-13 3:21 ` Joe Perches
2010-08-13 3:44 ` Karen Xie
2010-08-16 16:48 ` Joe Perches
2010-08-17 0:02 ` Karen Xie
2010-08-17 0:22 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282004557.24541.2.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=kxie@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=open-iscsi@googlegroups.com \
--cc=rakesh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox