public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Christoph Hellwig <hch@infradead.org>, "Ted Ts'o" <tytso@mit.edu>,
	H Hartley Sweeten <hartleys@visionengravers.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"matthew@wil.cx" <matthew@wil.cx>
Subject: Re: [PATCH] fs.h: introduce functions to get/set file->private_data
Date: Tue, 17 Aug 2010 18:32:22 -0700	[thread overview]
Message-ID: <1282095142.6724.11.camel@Joe-Laptop> (raw)
In-Reply-To: <20100817175851.GA11463@merkur.ravnborg.org>

On Tue, 2010-08-17 at 19:58 +0200, Sam Ravnborg wrote:
> It takes minimum effort to create and test, and if you can
> get ack from Ted and/or Christoph there is a good chance Linus
> would take it right before/after -rc1.
> 
> You obviously need to convince him that the patch has
> seen decent build testing.

private_data is the only non f_ prefixed member in
struct file, so while there is perhaps a tiny value
in this patch, I'm not in a hurry to push it.

After a few corrections, Documentation/, comment and
printk updates, a few macros that spatch didn't update,
etc, the diff that converts struct file member
private_data to f_private_data is now:

$ git diff --shortstat ..da5cabf80e2433131bf0ed8993abc0f7ea618c73
 511 files changed, 2638 insertions(+), 2639 deletions(-)

Does either Ted or Christoph want to see it?

Harley?  You want it?

It's still ~850BKB and probably shouldn't be posted to
the ML as it's mostly mechanical.

Compiles x86 allyesconfig, defconfig




  parent reply	other threads:[~2010-08-18  1:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-16 18:37 [PATCH] fs.h: introduce functions to get/set file->private_data H Hartley Sweeten
2010-08-16 23:17 ` Christoph Hellwig
2010-08-16 23:36   ` H Hartley Sweeten
2010-08-16 23:50     ` Joe Perches
2010-08-17  1:03       ` Ted Ts'o
2010-08-17  1:58         ` Joe Perches
2010-08-17  8:54         ` Christoph Hellwig
2010-08-17 17:26           ` Joe Perches
2010-08-17 17:58             ` Sam Ravnborg
2010-08-17 18:21               ` Joe Perches
2010-08-18  1:32               ` Joe Perches [this message]
2010-08-18 16:48                 ` H Hartley Sweeten
2010-08-18 17:15                   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282095142.6724.11.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=hartleys@visionengravers.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=sam@ravnborg.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox