From: Huang Ying <ying.huang@intel.com>
To: Jin Dongming <jin.dongming@np.css.fujitsu.com>,
Lu Yinghai <yinghai@kernel.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andi Kleen <andi@firstfloor.org>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
ACPI <linux-acpi@vger.kernel.org>,
LKLM <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] [Patch-next] ACPI, APEI, ERST Fix the wrong checking of Serialization Header's length
Date: Wed, 18 Aug 2010 13:34:56 +0800 [thread overview]
Message-ID: <1282109696.2744.1553.camel@yhuang-dev> (raw)
In-Reply-To: <4C6A139D.20507@np.css.fujitsu.com>
On Tue, 2010-08-17 at 12:44 +0800, Jin Dongming wrote:
> (2010/08/17 12:22), Huang Ying wrote:
> > On Tue, 2010-08-17 at 10:14 +0800, Jin Dongming wrote:
> >>> I don't think it is necessary to change the header definition, and
> >>> seri_header is not a good name for me.
> >> Why I added this structure here is that I don't want to do following checking.
> >> For example,
> >> if (header_length != 0x0c) {
> >> ...
> >> }
> >
> > This can be:
> >
> > static int erst_check_table(struct acpi_table_erst *erst_tab)
> > {
> > - if (erst_tab->header_length != sizeof(struct acpi_table_erst))
> > + if (erst_tab->header_length !=
> > + (sizeof(struct acpi_table_erst) - sizeof(erst_tab->header)))
> >
> > like Yinghai has been done.
> >
> Yes. It looks good. And I am sorry I am unaware of Yinghai' patch.
Maybe you can help push this fix in, it seems that Yinghai is busy on
something else?
Hi, Yinghai,
Do you mind for Dongming to push this fix?
Best REgards,
Huang Ying
next prev parent reply other threads:[~2010-08-18 5:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 0:54 [PATCH 1/4] [Patch-next] ACPI, APEI, ERST Fix the wrong checking of Serialization Header's length Jin Dongming
2010-08-17 1:33 ` Huang Ying
2010-08-17 2:14 ` Jin Dongming
2010-08-17 3:22 ` Huang Ying
2010-08-17 4:44 ` Jin Dongming
2010-08-18 5:34 ` Huang Ying [this message]
2010-08-18 8:35 ` Jin Dongming
2010-08-20 19:26 ` Yinghai Lu
2010-08-23 0:26 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282109696.2744.1553.camel@yhuang-dev \
--to=ying.huang@intel.com \
--cc=andi@firstfloor.org \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=sfr@canb.auug.org.au \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).