From: jiang.adam@gmail.com
To: ralf@linux-mips.org
Cc: dmitri.vorobiev@movial.com, wuzhangjin@gmail.com,
ddaney@caviumnetworks.com, peterz@infradead.org,
fweisbec@gmail.com, tj@kernel.org, tglx@linutronix.de,
mingo@elte.hu, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org, Adam Jiang <jiang.adam@gmail.com>
Subject: [PATCH] mips: irq: add statckoverflow detection
Date: Sat, 21 Aug 2010 15:31:33 +0900 [thread overview]
Message-ID: <1282372293-30211-1-git-send-email-jiang.adam@gmail.com> (raw)
From: Adam Jiang <jiang.adam@gmail.com>
Add stackoverflow detection to mips arch
Signed-off-by: Adam Jiang <jiang.adam@gmail.com>
---
arch/mips/Kconfig.debug | 7 +++++++
arch/mips/kernel/irq.c | 19 +++++++++++++++++++
2 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug
index 43dc279..f1a00a2 100644
--- a/arch/mips/Kconfig.debug
+++ b/arch/mips/Kconfig.debug
@@ -67,6 +67,13 @@ config CMDLINE_OVERRIDE
Normally, you will choose 'N' here.
+config DEBUG_STACKOVERFLOW
+ bool "Check for stack overflows"
+ depends on DEBUG_KERNEL
+ help
+ This option will cause messages to be printed if free stack space
+ drops below a certain limit.
+
config DEBUG_STACK_USAGE
bool "Enable stack utilization instrumentation"
depends on DEBUG_KERNEL
diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c
index c6345f5..6334037 100644
--- a/arch/mips/kernel/irq.c
+++ b/arch/mips/kernel/irq.c
@@ -151,6 +151,22 @@ void __init init_IRQ(void)
#endif
}
+static inline void check_stack_overflow(void)
+{
+#ifdef CONFIG_DEBUG_STACKOVERFLOW
+ long sp;
+
+ asm volatile("move %0, $sp" : "=r" (sp));
+ sp = sp & (THREAD_SIZE-1);
+
+ /* check for stack overflow: is there less then 2KB free? */
+ if (unlikely(sp < (sizeof(struct thread_info) + 2048))) {
+ printk("do_IRQ: stack overflow: %ld\n",
+ sp - sizeof(struct thread_info));
+ dump_stack();
+ }
+#endif
+}
/*
* do_IRQ handles all normal device IRQ's (the special
* SMP cross-CPU interrupts have their own specific
@@ -159,6 +175,9 @@ void __init init_IRQ(void)
void __irq_entry do_IRQ(unsigned int irq)
{
irq_enter();
+
+ check_stack_overflow();
+
__DO_IRQ_SMTC_HOOK(irq);
generic_handle_irq(irq);
irq_exit();
--
1.7.1
next reply other threads:[~2010-08-21 6:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 6:31 jiang.adam [this message]
2010-08-21 13:08 ` [PATCH] mips: irq: add statckoverflow detection Sergei Shtylyov
2010-08-25 20:28 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282372293-30211-1-git-send-email-jiang.adam@gmail.com \
--to=jiang.adam@gmail.com \
--cc=ddaney@caviumnetworks.com \
--cc=dmitri.vorobiev@movial.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox