From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751397Ab0HWA0j (ORCPT ); Sun, 22 Aug 2010 20:26:39 -0400 Received: from mga14.intel.com ([143.182.124.37]:12324 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249Ab0HWA0f (ORCPT ); Sun, 22 Aug 2010 20:26:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.56,254,1280732400"; d="scan'208";a="315635202" Subject: Re: [PATCH 1/4] [Patch-next] ACPI, APEI, ERST Fix the wrong checking of Serialization Header's length From: Huang Ying To: Yinghai Lu Cc: Jin Dongming , Randy Dunlap , Stephen Rothwell , Andi Kleen , Hidetoshi Seto , ACPI , LKLM In-Reply-To: <4C6ED6CD.4010002@kernel.org> References: <4C69DDB5.6060103@np.css.fujitsu.com> <1282008836.2744.1490.camel@yhuang-dev> <4C69F094.1040607@np.css.fujitsu.com> <1282015344.2744.1500.camel@yhuang-dev> <4C6A139D.20507@np.css.fujitsu.com> <1282109696.2744.1553.camel@yhuang-dev> <4C6ED6CD.4010002@kernel.org> Content-Type: text/plain; charset="UTF-8" Date: Mon, 23 Aug 2010 08:26:32 +0800 Message-ID: <1282523192.2744.1609.camel@yhuang-dev> Mime-Version: 1.0 X-Mailer: Evolution 2.30.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2010-08-21 at 03:26 +0800, Yinghai Lu wrote: > On 08/17/2010 10:34 PM, Huang Ying wrote: > > On Tue, 2010-08-17 at 12:44 +0800, Jin Dongming wrote: > >> (2010/08/17 12:22), Huang Ying wrote: > >>> On Tue, 2010-08-17 at 10:14 +0800, Jin Dongming wrote: > >>>>> I don't think it is necessary to change the header definition, and > >>>>> seri_header is not a good name for me. > >>>> Why I added this structure here is that I don't want to do following checking. > >>>> For example, > >>>> if (header_length != 0x0c) { > >>>> ... > >>>> } > >>> > >>> This can be: > >>> > >>> static int erst_check_table(struct acpi_table_erst *erst_tab) > >>> { > >>> - if (erst_tab->header_length != sizeof(struct acpi_table_erst)) > >>> + if (erst_tab->header_length != > >>> + (sizeof(struct acpi_table_erst) - sizeof(erst_tab->header))) > >>> > >>> like Yinghai has been done. > >>> > >> Yes. It looks good. And I am sorry I am unaware of Yinghai' patch. > > > > Maybe you can help push this fix in, it seems that Yinghai is busy on > > something else? > > > > Hi, Yinghai, > > > > Do you mind for Dongming to push this fix? > > > do you mean this one? > > [PATCH] acpi: fix apei related table size checking > > Signed-off-by: Yinghai Lu Acked-by: Huang Ying