From: Peter Zijlstra <peterz@infradead.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ian Jackson <ijackson@chiark.greenend.org.uk>,
Greg KH <gregkh@suse.de>, Ian Campbell <ijc@hellion.org.uk>,
linux-kernel@vger.kernel.org, stable@kernel.org,
stable-review@kernel.org, akpm@linux-foundation.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: [RFC] mlock/stack guard interaction fixup
Date: Mon, 23 Aug 2010 21:07:37 +0200 [thread overview]
Message-ID: <1282590457.2605.2200.camel@laptop> (raw)
In-Reply-To: <4C72C2E9.3070408@goop.org>
On Mon, 2010-08-23 at 11:50 -0700, Jeremy Fitzhardinge wrote:
> On 08/23/2010 10:34 AM, Linus Torvalds wrote:
> > Quite frankly, I personally believe that people who play games with
> > mlock are misguided. The _one_ special case is for protecting keys or
> > private data that you do not want to hit the disk in some unencrypted
> > mode, and quite frankly, you should strive to handle those way more
> > specially than just putting them in some random place ("on the stack"
> > or "in some malloc()'ed area"). The sane model for doing that is
> > generally to explicitly mmap() and mlock the area, so that you get a
> > very controlled access pattern, and never have to worry about things
> > like COW etc.
>
> Is that guaranteed to work (in Linux or in general)? mlock has always
> meant "won't generate disk IO to fault in/evicted", but does it prevent
> dirty pages from being written out so long as they also remain
> resident? Or does it depend on the precise type of page you're
> mlocking? For example, what does mlock on a shared writeable mapping mean?
mlock() simply avoids major faults, nothing more.
I think both page migration and page-out for shared pages where some
maps are !mlocked can cause unmaps and thus minor faults.
mlock and dirty do not interact, they will still be cleaned/written out
as normal.
next prev parent reply other threads:[~2010-08-23 19:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 23:59 [RFC] mlock/stack guard interaction fixup Linus Torvalds
2010-08-21 0:20 ` Mike Snitzer
2010-08-21 0:54 ` Linus Torvalds
2010-08-21 11:56 ` Ian Campbell
2010-08-21 15:48 ` Linus Torvalds
2010-08-21 16:08 ` Sam Ravnborg
2010-08-23 16:34 ` Tony Luck
2010-08-22 6:57 ` Ian Campbell
2010-08-22 7:33 ` Ian Campbell
2010-08-22 9:55 ` Ian Campbell
2010-08-22 16:43 ` Linus Torvalds
2010-08-22 17:25 ` Greg KH
2010-08-22 18:21 ` Linus Torvalds
2010-08-22 19:04 ` Greg KH
2010-08-23 9:22 ` Peter Zijlstra
2010-08-23 15:42 ` ijackson
2010-08-23 16:25 ` Peter Zijlstra
2010-08-23 17:18 ` Ian Jackson
2010-08-23 17:34 ` Linus Torvalds
2010-08-23 17:53 ` Peter Zijlstra
2010-08-23 17:59 ` Peter Zijlstra
2010-08-23 18:43 ` Darren Hart
2010-08-23 18:50 ` Jeremy Fitzhardinge
2010-08-23 19:07 ` Peter Zijlstra [this message]
2010-08-23 19:23 ` Jeremy Fitzhardinge
2010-08-23 19:26 ` Peter Zijlstra
2010-08-23 19:54 ` Jeremy Fitzhardinge
2010-08-24 7:08 ` Peter Zijlstra
2010-08-24 7:20 ` Peter Zijlstra
2010-08-23 19:03 ` Ian Campbell
2010-08-23 17:40 ` Peter Zijlstra
2010-08-23 18:53 ` Jeremy Fitzhardinge
2010-08-25 8:28 ` [Stable-review] " Stefan Bader
2010-08-23 9:00 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282590457.2605.2200.camel@laptop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=ijackson@chiark.greenend.org.uk \
--cc=ijc@hellion.org.uk \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox