From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: soc-core: fix debugfs_pop_time file permissions
Date: Fri, 27 Aug 2010 13:25:00 +0100 [thread overview]
Message-ID: <1282911900.3025.7.camel@odin> (raw)
In-Reply-To: <1282876467.9142.2.camel@mola>
On Fri, 2010-08-27 at 10:34 +0800, Axel Lin wrote:
> I think this is a typo, debugfs_pop_time should not be executable.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/soc-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 65352c7..42542e0 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -249,7 +249,7 @@ static void soc_init_codec_debugfs(struct snd_soc_codec *codec)
> printk(KERN_WARNING
> "ASoC: Failed to create codec register debugfs file\n");
>
> - codec->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0744,
> + codec->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0644,
> codec->debugfs_codec_root,
> &codec->pop_time);
> if (!codec->debugfs_pop_time)
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-08-27 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 2:34 [PATCH] ASoC: soc-core: fix debugfs_pop_time file permissions Axel Lin
2010-08-27 12:25 ` Liam Girdwood [this message]
2010-08-27 19:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282911900.3025.7.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox