From: Colin Cross <ccross@android.com>
To: linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org
Cc: Colin Cross <ccross@android.com>, Pavel Machek <pavel@ucw.cz>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Alan Stern <stern@rowland.harvard.edu>,
Randy Dunlap <randy.dunlap@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] PM: Prevent waiting forever on asynchronous resume after abort
Date: Wed, 1 Sep 2010 19:54:12 -0700 [thread overview]
Message-ID: <1283396052-3620-1-git-send-email-ccross@android.com> (raw)
Only wait on a parent device during resume if the parent device is
suspended.
Consider three drivers, A, B, and C. The parent of A is C, and C
has async_suspend set. On boot, C->power.completion is initialized
to 0.
During the first suspend:
suspend_devices_and_enter(...)
dpm_resume(...)
device_suspend(A)
device_suspend(B) returns error, aborts suspend
dpm_resume_end(...)
dpm_resume(...)
device_resume(A)
dpm_wait(A->parent == C)
wait_for_completion(C->power.completion)
The wait_for_completion will never complete, because
complete_all(C->power.completion) will only be called from
device_suspend(C) or device_resume(C), neither of which is called
if suspend is aborted before C.
After a successful suspend->resume cycle, where B doesn't abort
suspend, C->power.completion is left in the completed state by the
call to device_resume(C), and the same call path will work if B
aborts suspend.
Signed-off-by: Colin Cross <ccross@android.com>
---
drivers/base/power/main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index cb784a0..e159910 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -526,7 +526,8 @@ static int device_resume(struct device *dev, pm_message_t state, bool async)
TRACE_DEVICE(dev);
TRACE_RESUME(0);
- dpm_wait(dev->parent, async);
+ if (dev->parent && dev->parent->power.status >= DPM_OFF)
+ dpm_wait(dev->parent, async);
device_lock(dev);
dev->power.status = DPM_RESUMING;
--
1.7.1
next reply other threads:[~2010-09-02 2:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 2:54 Colin Cross [this message]
2010-09-02 13:50 ` [PATCH] PM: Prevent waiting forever on asynchronous resume after abort Alan Stern
2010-09-02 19:46 ` Rafael J. Wysocki
2010-09-02 20:24 ` Colin Cross
2010-09-02 20:30 ` Rafael J. Wysocki
2010-09-02 20:45 ` Alan Stern
2010-09-02 21:01 ` Colin Cross
2010-09-02 21:06 ` Rafael J. Wysocki
2010-09-02 21:34 ` Alan Stern
2010-09-02 22:45 ` Colin Cross
2010-09-02 23:09 ` Rafael J. Wysocki
2010-09-03 0:14 ` Colin Cross
2010-09-03 0:35 ` Rafael J. Wysocki
2010-09-03 1:54 ` Colin Cross
2010-09-03 2:42 ` Alan Stern
2010-09-03 4:30 ` Colin Cross
2010-09-03 14:04 ` Alan Stern
2010-09-03 16:48 ` Colin Cross
2010-09-03 17:31 ` Alan Stern
2010-09-16 20:36 ` [PATCH] PM: Fix potential issue with failing asynchronous suspend (was: Re: [PATCH] PM: Prevent waiting ...) Rafael J. Wysocki
2010-09-16 21:00 ` Alan Stern
2010-09-16 21:24 ` Rafael J. Wysocki
2010-09-02 21:05 ` [PATCH] PM: Prevent waiting forever on asynchronous resume after abort Rafael J. Wysocki
2010-09-02 21:31 ` Colin Cross
2010-09-02 21:40 ` Rafael J. Wysocki
2010-09-02 22:59 ` [PATCH v2] " Colin Cross
2010-09-02 23:25 ` Rafael J. Wysocki
2010-09-02 20:27 ` [PATCH] " Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283396052-3620-1-git-send-email-ccross@android.com \
--to=ccross@android.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=randy.dunlap@oracle.com \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox