public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Stefani Seibold <stefani@seibold.net>
Cc: David Woodhouse <dwmw2@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"Enzinger,
	Robert (EXT-Other - DE/Munich)"  <robert.enzinger.ext@nsn.com>
Subject: Re: [PATCH] Add quick erase format option
Date: Thu, 02 Sep 2010 13:58:20 +0300	[thread overview]
Message-ID: <1283425100.3085.5.camel@brekeke> (raw)
In-Reply-To: <1283410392.6920.36.camel@wall-e.seibold.net>

On Thu, 2010-09-02 at 08:53 +0200, Stefani Seibold wrote: 
> --do-not-use-me is the best. But more seriously i think we should it
> split it into two options. --all-erased and --check-erased. The first
> assumes that all PEB are erased, while the second do the check if the
> PEB is erased and if not it will be erased.
> 
> So we can handle NAND's, which have a fast erase, and NOR's  which are
> very slow. With this we are able to pick the best option for the
> manufacturing.

I am fine with checking, but what bothers me is that you check only 64
bytes out of 128KiB - why this is enough to make sure the eraseblock is
erased?

Probably it is ok for you, but in for general use-case this is wrong,
even checking all 128KiB is wrong, because of the unstable bits.

What I think will make more sense is to add general option --verify or
something like that. It would read everything the utility wrote and
verify it is identical to what was written. Probably this can be done in
libmtd.

Then you will be able to combine --all-erased with --verify and achieve
what you want.

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)



  reply	other threads:[~2010-09-02 10:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-09  8:25 [PATCH] Add quick erase format option stefani
2010-08-09  8:37 ` David Woodhouse
2010-08-09  8:52   ` Stefani Seibold
2010-08-09 11:29     ` Artem Bityutskiy
2010-08-09 13:37       ` Stefani Seibold
2010-08-09 13:54       ` Stefani Seibold
2010-08-29 11:30         ` Artem Bityutskiy
2010-08-29 12:20           ` Artem Bityutskiy
2010-08-31  6:42           ` Stefani Seibold
2010-09-01  0:47             ` Artem Bityutskiy
2010-09-02  6:53               ` Stefani Seibold
2010-09-02 10:58                 ` Artem Bityutskiy [this message]
2010-09-02 11:42                   ` Stefani Seibold
2018-06-20  5:38     ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283425100.3085.5.camel@brekeke \
    --to=dedekind1@gmail.com \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=robert.enzinger.ext@nsn.com \
    --cc=stefani@seibold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox