From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andy Whitcroft <apw@canonical.com>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFD][checkpatch] warnings on space in front of labels
Date: Thu, 02 Sep 2010 16:31:07 +0200 [thread overview]
Message-ID: <1283437867.2012.213.camel@laptop> (raw)
In-Reply-To: <1283437098.2356.135.camel@gandalf.stny.rr.com>
On Thu, 2010-09-02 at 10:18 -0400, Steven Rostedt wrote:
>
> There's a new warning that I've seen lately. It is about complaining
> about spaces starting on a new line.
>
> WARNING: please, no space for starting a line,
> excluding comments
> #90: FILE: trace-read.c:612:
> + again:$
>
>
> Comments are currently the exception, but I would also like to add
> labels too.
I really hate that /^ label/ stuff and I'm removing them everywhere I
can.
> I really prefer the space in front of the label. In fact, I think it
> should be the default.
>
> But could we at least remove the warning for spaces in front of labels?
No, kill those spaces with prejudice.
> What do others think?
I'd prefer to run a script over the kernel and remove all those silly spaces.
next prev parent reply other threads:[~2010-09-02 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 14:18 [RFD][checkpatch] warnings on space in front of labels Steven Rostedt
2010-09-02 14:29 ` Andy Whitcroft
2010-09-02 14:31 ` Peter Zijlstra [this message]
2010-09-02 14:43 ` Steven Rostedt
2010-09-02 15:12 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283437867.2012.213.camel@laptop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox