From: "Alexander van Heukelum" <heukelum@fastmail.fm>
To: "Jan Beulich" <JBeulich@novell.com>,
"Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Resend: [PATCH] x86-64: fix unwind annotations in syscall stubs
Date: Fri, 03 Sep 2010 00:49:35 +0200 [thread overview]
Message-ID: <1283467775.10264.1393103393@webmail.messagingengine.com> (raw)
In-Reply-To: <4C7FBA3D0200007800013F61@vpn.id2.novell.com>
On Thu, 02 Sep 2010 13:52 +0100, "Jan Beulich" <JBeulich@novell.com> wrote:
> With the return address removed from the stack, these should really
> refer to their caller's register state.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> ---
> arch/x86/kernel/entry_64.S | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> --- linux-2.6.36-rc3/arch/x86/kernel/entry_64.S
> +++ 2.6.36-rc3-x86_64-stub-unwind-annotations/arch/x86/kernel/entry_64.S
> @@ -714,9 +714,8 @@ END(ptregscall_common)
>
> ENTRY(stub_execve)
> CFI_STARTPROC
> - popq %r11
> - CFI_ADJUST_CFA_OFFSET -8
> - CFI_REGISTER rip, r11
> + addq $8, %rsp
> + PARTIAL_FRAME 0
> SAVE_REST
> FIXUP_TOP_OF_STACK %r11
> movq %rsp, %rcx
> @@ -735,7 +734,7 @@ END(stub_execve)
> ENTRY(stub_rt_sigreturn)
> CFI_STARTPROC
> addq $8, %rsp
> - CFI_ADJUST_CFA_OFFSET -8
> + PARTIAL_FRAME 0
> SAVE_REST
> movq %rsp,%rdi
> FIXUP_TOP_OF_STACK %r11
>
Thanks for creating these...
Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>
next prev parent reply other threads:[~2010-09-02 22:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 12:52 Resend: [PATCH] x86-64: fix unwind annotations in syscall stubs Jan Beulich
2010-09-02 22:49 ` Alexander van Heukelum [this message]
2010-09-03 7:11 ` [tip:x86/debug] x86-64: Fix " tip-bot for Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2010-09-02 12:53 Resend: [PATCH] x86-64: fix " Jan Beulich
2010-09-02 22:50 ` Alexander van Heukelum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283467775.10264.1393103393@webmail.messagingengine.com \
--to=heukelum@fastmail.fm \
--cc=JBeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox