From: "Alexander van Heukelum" <heukelum@fastmail.fm>
To: "Jan Beulich" <JBeulich@novell.com>,
"Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Resend: [PATCH] x86-64: fix unwind annotations in syscall stubs
Date: Fri, 03 Sep 2010 00:50:47 +0200 [thread overview]
Message-ID: <1283467847.11165.1393104277@webmail.messagingengine.com> (raw)
In-Reply-To: <4C7FBA790200007800013F64@vpn.id2.novell.com>
On Thu, 02 Sep 2010 13:53 +0100, "Jan Beulich" <JBeulich@novell.com> wrote:
> The scope should really extend to the end of the function, not the
> return location.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> ---
> arch/x86/kernel/entry_64.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.36-rc3/arch/x86/kernel/entry_64.S
> +++ 2.6.36-rc3-x86_64-error_entry-unwind-scope/arch/x86/kernel/entry_64.S
> @@ -1445,7 +1445,6 @@ error_swapgs:
> error_sti:
> TRACE_IRQS_OFF
> ret
> - CFI_ENDPROC
>
> /*
> * There are two places in the kernel that can potentially fault with
> @@ -1470,6 +1469,7 @@ bstep_iret:
> /* Fix truncated RIP */
> movq %rcx,RIP+8(%rsp)
> jmp error_swapgs
> + CFI_ENDPROC
> END(error_entry)
>
Indeed.
Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>
next prev parent reply other threads:[~2010-09-02 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 12:53 Resend: [PATCH] x86-64: fix unwind annotations in syscall stubs Jan Beulich
2010-09-02 22:50 ` Alexander van Heukelum [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-09-02 12:52 Jan Beulich
2010-09-02 22:49 ` Alexander van Heukelum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283467847.11165.1393104277@webmail.messagingengine.com \
--to=heukelum@fastmail.fm \
--cc=JBeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox