Re: [PATCH] Revert "drm/i915: fix vblank wait test condition"

Fabio Comolli
2010-09-05T10:13:35Z

Hi.

On Sun, Sep 5, 2010 at 11:14 AM, Sitsofe Wheeler <sitsofe@yahoo.com> wrote:
> On Sun, Sep 05, 2010 at 10:26:25AM +0200, Fabio Comolli wrote:
>>
>> Well, this is very strange. I also own an EeePC 900 (i915 of course)
>> and I don't have this problem at all, nor I need the patch. Actually I
>> run a plain 2.6.36-rc3 and it works perfectly.
>>
>> I use the latest userspace available, with xorg 1.9 and Intel video
>> driver v. 2.12 (Archlinux testing repositories).
>>
>> Which kernel / userspace are you using?
>
> OK that's interesting - are you seeing correct xrandr output after a
> suspend and resume too?

Yes:

[root@ratbert] - [~] xrandr
Screen 0: minimum 320 x 200, current 1024 x 600, maximum 4096 x 4096
LVDS1 connected 1024x600+0+0 (normal left inverted right x axis y
axis) 0mm x 0mm
1024x600 59.5*+
800x600 85.1 72.2 75.0 60.3 56.2
640x480 85.0 72.8 75.0 59.9
720x400 85.0
640x400 85.1
640x350 85.1
VGA1 disconnected (normal left inverted right x axis y axis)
TV1 disconnected (normal left inverted right x axis y axis)

(just resumed from suspend-to-ram - no hibernation configured)

> I previously said that everything was working
> perfectly a few weeks ago (only correct inputs were reported, only one
> FIFO message in dmesg, no tearing on video, no cursor disappearing,
> screen size was correct when X started, running xrandr doesn't make the
> screen flash white etc) and added my tested-by line only to find out
> that there were cases where phantom inputs were still being reported (
> http://marc.info/?l=linux-kernel&m=128272404206696&w=2 ).
>
> I'm using a 2.6.36-rc3 kernel (with the patch). I think userspace X is
> less relevant as I can reproduce the false VGA detection without X
> starting please see http://bugs.freedesktop.org/show_bug.cgi?id=29857
> for more details).  I've tested the 2.12 intel drivers which you can add
> via xorg-edgers (which I think was 1.8 but I'd have to check) and the
> 2.9 drivers which ship with Ubuntu 10.04 (which is xorg 1.7.6). The
> newer X userspace pieces show a nice speedup in things like desktop
> effects and textured video but if X doesn't run and inputs are being
> mis-detected then I don't think it is the root of the problem...
>
> I'm interested to know if it is just me seeing this issue. Did you even
> have a problem with 2.6.36-rc2? Do you have any debugging options (e.g.
> lock dep checking) on that would slow your kernel down and stop the
> issue from ocurring?
>

Never had this kind of issues. I also tested rc2 without problems.

> --
> Sitsofe | http://sucs.org/~sits/
>

Regards,
Fabio