Re: [PATCH] Revert "drm/i915: fix vblank wait test condition"

Pekka Enberg
2010-09-05T16:40:09Z

On Sun, 05 Sep 2010 19:11:16 +0300, Pekka Enberg <penberg@kernel.org> wrote:
>> Is someone picking this patch up or am I supposed to send it to Linus?

On Sun, Sep 5, 2010 at 7:23 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> I have applied this patch to
>
> http://cgit.freedesktop.org/~ickle/drm-intel/
>
> Thanks.

The "drm-intel" branch on top of 2.6.36-rc3 works OK on my machine. I
do see the following errors in dmesg but they seem to be harmless:

[ 1.004937] render error detected, EIR: 0x00000010
[ 1.004981] page table error
[ 1.005018] PGTBL_ER: 0x00000102
[ 1.005058] [drm:i915_report_and_clear_eir] *ERROR* EIR stuck:
0x00000010, masking
[ 1.005139] render error detected, EIR: 0x00000010
[ 1.005194] page table error
[ 1.005244] PGTBL_ER: 0x00000102
[ 1.660043] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.

[snip]

[ 4.950117] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 5.176515] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 5.420040] usb 5-1: new full speed USB device using uhci_hcd and address 3
[ 5.570066] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 5.776699] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 7.830162] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 8.036329] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 8.412362] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 8.616325] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 8.992369] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 9.196325] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 14.250106] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 14.456280] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 14.852445] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 15.054263] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 15.432298] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 15.636248] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 16.560078] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.
[ 16.766246] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
plane, expect flickering: entries required = 36, available = 31.

Pekka