Re: [tip:x86/irq] x86: Always use irq stacks

["Alexander van Heukelum" <heukelum@fastmail.fm>]

On Tue, 07 Sep 2010 06:55 +0200, "Ingo Molnar" <mingo@elte.hu> wrote:
> 
> * Alexander van Heukelum <heukelum@fastmail.fm> wrote:
> 
> > On Fri, 03 Sep 2010 17:00 +0200, "Ingo Molnar" <mingo@elte.hu> wrote:
> > > 
> > > * tip-bot for Christoph Hellwig <hch@lst.de> wrote:
> > > 
> > > > Commit-ID:  7974891db234467eaf1fec613ec0129cb4ac2332
> > > > Gitweb:     http://git.kernel.org/tip/7974891db234467eaf1fec613ec0129cb4ac2332
> > > > Author:     Christoph Hellwig <hch@lst.de>
> > > > AuthorDate: Mon, 28 Jun 2010 14:15:54 +0200
> > > > Committer:  Thomas Gleixner <tglx@linutronix.de>
> > > > CommitDate: Tue, 29 Jun 2010 12:12:59 +0200
> > > > 
> > > > x86: Always use irq stacks
> > >
> > > [...]
> > > 
> > > Checking out 7974891db2 and building+booting a kernel with this config 
> > > causes shows the crash.
> > > 
> > > Checking out 7974891db2~1 and building+booting a kernel with this config 
> > > gives a working system.
> > > 
> > > Note that tip:x86/irq has these commits currently:
> > > 
> > >  1813a68: x86: Move alloc_desk_mask variables inside ifdef
> > >  2589737: x86-32: Align IRQ stacks properly
> > >  dcfa726: x86: Remove CONFIG_4KSTACKS
> > >  7974891: x86: Always use irq stacks
> > 
> > Hello Ingo, Christoph, ...
> > 
> > There is still a problem with the alignment of the irq stacks. Maybe it's only
> > theoretical, but I think the attached patch is necessary. (Attached because
> > I'm sending it via a web interface.)
> > 
> > Please test and apply :).
> 
> This apparently solved the crash, thanks a lot Alexander!

My pleasure!

Greetings,
    Alexander

> 	Ingo
>