From: Artem Bityutskiy <dedekind1@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: jaxboe@fusionio.com, linux-kernel@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 5/5] backing-dev: replace sync_supers_tsk/timer with a delayed_work
Date: Wed, 08 Sep 2010 12:00:51 +0300 [thread overview]
Message-ID: <1283936451.2979.65.camel@localhost> (raw)
In-Reply-To: <1283777182-11426-6-git-send-email-tj@kernel.org>
On Mon, 2010-09-06 at 14:46 +0200, Tejun Heo wrote:
> sync_supers_task/timer can trivially replaced with a delayed_work. As
> it's not on the allocation path, run it on the system_wq.
>
> NOTE: Both before and after this patch, sync_supers is not freezeable.
> This might need to be changed.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> mm/backing-dev.c | 49 ++++++++++++++-----------------------------------
> 1 files changed, 14 insertions(+), 35 deletions(-)
Actually what Al Viro wants is to make sync_supers() go away and make
every FS to take care of its own superblock. So I guess this change is
useful in a sense that it'll be then easier to push this down to FSes.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-09-08 9:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 12:46 [PATCHSET] backing-dev: replace private thread pool with workqueue Tejun Heo
2010-09-06 12:46 ` [PATCH 1/5] workqueue: implement workqueue_on_rescuer() Tejun Heo
2010-09-06 12:46 ` [PATCH 2/5] backing-dev: kill unused bdi_writeback->nr Tejun Heo
2010-09-08 8:57 ` Artem Bityutskiy
2010-09-06 12:46 ` [PATCH 3/5] backing-dev: replace private thread pool with workqueue Tejun Heo
2010-09-06 12:46 ` [PATCH 4/5] backing-dev: update trace points Tejun Heo
2010-09-06 12:46 ` [PATCH 5/5] backing-dev: replace sync_supers_tsk/timer with a delayed_work Tejun Heo
2010-09-08 9:00 ` Artem Bityutskiy [this message]
2010-09-07 12:16 ` [PATCHSET] backing-dev: replace private thread pool with workqueue Christoph Hellwig
2010-09-07 12:19 ` Tejun Heo
2010-09-07 12:29 ` Jens Axboe
2010-09-07 12:36 ` Tejun Heo
2010-11-27 16:02 ` Tejun Heo
2010-11-27 18:50 ` Jens Axboe
2010-11-27 20:30 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283936451.2979.65.camel@localhost \
--to=dedekind1@gmail.com \
--cc=hch@lst.de \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox