From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754020Ab0IITdc (ORCPT ); Thu, 9 Sep 2010 15:33:32 -0400 Received: from mail.perches.com ([173.55.12.10]:1574 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752657Ab0IITda (ORCPT ); Thu, 9 Sep 2010 15:33:30 -0400 Subject: Re: [rfc patch] treewide: Convert "static const char <*> foo[] =" to "static const char <*> const foo[] =" From: Joe Perches To: Mike Frysinger Cc: LKML In-Reply-To: References: <1284056536.24986.182.camel@Joe-Laptop> <1284058127.24986.199.camel@Joe-Laptop> Content-Type: text/plain; charset="UTF-8" Date: Thu, 09 Sep 2010 12:33:28 -0700 Message-ID: <1284060808.24986.231.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2010-09-09 at 15:16 -0400, Mike Frysinger wrote: > On Thu, Sep 9, 2010 at 14:48, Joe Perches wrote: > > could be warned by checkpatch > i dont think you even need to check the contents. just match the base: > char foo[] > const char *foo[] > we want to catch these even if it isnt static, and catching the > forward decl would be useful too. I think that's not so good. There are times when a default is used but then modified. For instance: drivers/staging/comedi/drivers/comedi_bond.c: char file[] = "/dev/comediXXXXXX"; > your perl hack isnt quite right. The script I posted doesn't eat that whitespace. The diff I sent you did. I wouldn't post that. > how about making a coccinelle patch ? Not necessary I think. If Julia or anyone else wants to, no objection.