From: Javier Martinez Canillas <martinez.javier@gmail.com>
To: Len Brown <lenb@kernel.org>, Huang Ying <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] ACPI: apei: Cast u64 to unsigned long, fix compile warning
Date: Sun, 12 Sep 2010 09:48:25 -0400 [thread overview]
Message-ID: <1284299305.7239.4.camel@lenovo> (raw)
In today linux-net I got a compile warning in acpi/apei
drivers/acpi/apei/erst.c: In function ‘erst_exec_move_data’:
drivers/acpi/apei/erst.c:273: warning: cast to pointer from integer of different size
drivers/acpi/apei/erst.c:274: warning: cast to pointer from integer of different size
The problem is that apei_exec_context->dst_base type is u64.
But in 32 bits architecture void * is 32 bits long.
Casting it to unsigned long solves the issue
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
---
drivers/acpi/apei/erst.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
index a4904f1..37d7a05 100644
--- a/drivers/acpi/apei/erst.c
+++ b/drivers/acpi/apei/erst.c
@@ -270,8 +270,8 @@ static int erst_exec_move_data(struct apei_exec_context *ctx,
rc = __apei_exec_read_register(entry, &offset);
if (rc)
return rc;
- memmove((void *)ctx->dst_base + offset,
- (void *)ctx->src_base + offset,
+ memmove((void *)(unsigned long)ctx->dst_base + offset,
+ (void *)(unsigned long)ctx->src_base + offset,
ctx->var2);
return 0;
--
1.7.0.4
next reply other threads:[~2010-09-12 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-12 13:48 Javier Martinez Canillas [this message]
2010-09-13 20:00 ` [PATCH] ACPI: apei: Cast u64 to unsigned long, fix compile warning Andrew Morton
2010-09-14 0:54 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284299305.7239.4.camel@lenovo \
--to=martinez.javier@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox