From: Vasiliy Kulikov <segooon@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Jarod Wilson <jarod@redhat.com>,
Manu Abraham <abraham.manu@gmail.com>,
Scott Davilla <davilla@4pi.com>,
Lars Lindley <lindley@coyote.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: crystalhd: fix signed bug
Date: Sun, 12 Sep 2010 22:56:51 +0400 [thread overview]
Message-ID: <1284317813-4895-1-git-send-email-segooon@gmail.com> (raw)
chd_dec_major is unsigned, so check chd_dec_major < 0 doesn't make sense.
Since it is used as signed, declare it as int.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
Compile tested.
drivers/staging/crystalhd/crystalhd_lnx.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.h b/drivers/staging/crystalhd/crystalhd_lnx.h
index c951e43..a2b5a56 100644
--- a/drivers/staging/crystalhd/crystalhd_lnx.h
+++ b/drivers/staging/crystalhd/crystalhd_lnx.h
@@ -76,7 +76,7 @@ struct crystalhd_adp {
spinlock_t lock;
/* API Related */
- unsigned int chd_dec_major;
+ int chd_dec_major;
unsigned int cfg_users;
struct crystalhd_ioctl_data *idata_free_head; /* ioctl data pool */
--
1.7.0.4
next reply other threads:[~2010-09-12 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-12 18:56 Vasiliy Kulikov [this message]
2010-09-28 19:01 ` [PATCH] staging: crystalhd: fix signed bug Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284317813-4895-1-git-send-email-segooon@gmail.com \
--to=segooon@gmail.com \
--cc=abraham.manu@gmail.com \
--cc=davilla@4pi.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jarod@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox