From: Vasiliy Kulikov <segooon@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Gregory Bean <gbean@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] gpio: sx150x: fix error code value
Date: Sun, 12 Sep 2010 22:57:24 +0400 [thread overview]
Message-ID: <1284317845-5181-1-git-send-email-segooon@gmail.com> (raw)
The return code of sx150x_get_io() is propagated as error code,
so it should look like standard code.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
Compile tested.
drivers/gpio/sx150x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/sx150x.c b/drivers/gpio/sx150x.c
index b42f42c..b0eed89 100644
--- a/drivers/gpio/sx150x.c
+++ b/drivers/gpio/sx150x.c
@@ -179,7 +179,7 @@ static int sx150x_get_io(struct sx150x_chip *chip, unsigned offset)
sx150x_find_cfg(offset, 1, ®, &mask, &shift);
err = sx150x_i2c_read(chip->client, reg, &data);
if (err >= 0)
- err = (data & mask) != 0 ? 1 : 0;
+ err = (data & mask) != 0 ? -EIO : 0;
return err;
}
--
1.7.0.4
next reply other threads:[~2010-09-12 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-12 18:57 Vasiliy Kulikov [this message]
2010-09-13 16:23 ` [PATCH] gpio: sx150x: fix error code value Gregory Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284317845-5181-1-git-send-email-segooon@gmail.com \
--to=segooon@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gbean@codeaurora.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox