From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208Ab0IMPYv (ORCPT ); Mon, 13 Sep 2010 11:24:51 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:56457 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753114Ab0IMPYt convert rfc822-to-8bit (ORCPT ); Mon, 13 Sep 2010 11:24:49 -0400 Subject: Re: [PATCH] perf_events: improve DS/BTS/PEBS buffer allocation From: Peter Zijlstra To: Stephane Eranian Cc: Frederic Weisbecker , Mathieu Desnoyers , linux-kernel@vger.kernel.org, mingo@elte.hu, paulus@samba.org, davem@davemloft.net, perfmon2-devel@lists.sf.net, eranian@gmail.com, robert.richter@amd.com, markus.t.metzger@intel.com, "markus.t.metzger" In-Reply-To: References: <4c8e3c0c.12d1d80a.73d9.ffffcf21@mx.google.com> <20100913150914.GA6155@nowhere> <1284391000.2275.338.camel@laptop> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Mon, 13 Sep 2010 17:24:40 +0200 Message-ID: <1284391480.2275.350.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2010-09-13 at 17:20 +0200, Stephane Eranian wrote: > That is the case we the sizes you have chosen today. For DS, we > could round up to one page for now. Markus chose the BTS size, for PEBS a single page was plenty since we do single event things (although we could do multiple for attr.precise_ip < 2). For DS there's: kmalloc_node(sizeof(struct ds), GFP_KERNEL | __GFP_ZERO, cpu_node(cpu));