From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754686Ab0IOVt2 (ORCPT ); Wed, 15 Sep 2010 17:49:28 -0400 Received: from mx1.vsecurity.com ([209.67.252.12]:60971 "EHLO mx1.vsecurity.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751961Ab0IOVt1 (ORCPT ); Wed, 15 Sep 2010 17:49:27 -0400 X-Greylist: delayed 380 seconds by postgrey-1.27 at vger.kernel.org; Wed, 15 Sep 2010 17:49:27 EDT Subject: [PATCH v2] drivers/net/eql.c: prevent reading uninitialized stack memory From: Dan Rosenberg To: linux-kernel@vger.kernel.org Cc: netdev@vger.kernel.org, security@kernel.org, stable@kernel.org Content-Type: text/plain; charset="UTF-8" Date: Wed, 15 Sep 2010 17:43:04 -0400 Message-ID: <1284586984.6275.92.camel@dan> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixed formatting (tabs and line breaks). The EQL_GETMASTRCFG device ioctl allows unprivileged users to read 16 bytes of uninitialized stack memory, because the "master_name" member of the master_config_t struct declared on the stack in eql_g_master_cfg() is not altered or zeroed before being copied back to the user. This patch takes care of it. Signed-off-by: Dan Rosenberg --- linux-2.6.35.4.orig/drivers/net/eql.c 2010-08-26 19:47:12.000000000 -0400 +++ linux-2.6.35.4/drivers/net/eql.c 2010-09-14 21:25:27.719474445 -0400 @@ -555,6 +555,8 @@ static int eql_g_master_cfg(struct net_d equalizer_t *eql; master_config_t mc; + memset(&mc, 0, sizeof(master_config_t)); + if (eql_is_master(dev)) { eql = netdev_priv(dev); mc.max_slaves = eql->max_slaves;