From: Joe Perches <joe@perches.com>
To: florian@mickler.org
Cc: linux-kernel@vger.kernel.org, ebiederm@xmission.com,
greg@kroah.com, stefanr@s5r6.in-berlin.de,
broonie@opensource.wolfsonmicro.com,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH] scripts/get_maintainer.pl: fix .mailmap handling
Date: Mon, 20 Sep 2010 17:14:45 -0700 [thread overview]
Message-ID: <1285028085.25988.60.camel@Joe-Laptop> (raw)
In-Reply-To: <1285022156-14501-1-git-send-email-florian@mickler.org>
On Tue, 2010-09-21 at 00:35 +0200, florian@mickler.org wrote:
> From: florian@mickler.org <florian@mickler.org>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
[]
> - my ($name, $address) = parse_email($line);
> - $line = format_email($name, $address, $email_usename);
> + next if (/^\s*$/); #skip empty lines
> + #print "entry: \"$_\"\n";
Please do not add commented out debugging code.
Add and use use some centralized debug(foo) call.
[]
> +sub mailmap {
> + my (@addresses) = @_;
> +
> + my @ret = ();
Suboptimal naming. I try to use descriptive names.
cheers, Joe
next prev parent reply other threads:[~2010-09-21 0:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 12:13 [PATCH rfc] scripts/get_maintainer.pl: add interactive mode florian
2010-09-15 13:43 ` [v2 PATCH " florian
2010-09-15 15:16 ` [PATCH RFC v3] " florian
2010-09-15 15:35 ` Joe Perches
2010-09-20 19:43 ` [RFC PATCH] " Joe Perches
2010-09-20 21:53 ` Florian Mickler
2010-09-20 22:27 ` [PATCH] scripts/get_maintainer.pl: fix .mailmap handling florian
2010-09-20 22:35 ` florian
2010-09-21 0:14 ` Joe Perches [this message]
2010-09-21 4:59 ` Florian Mickler
2010-09-21 5:20 ` Joe Perches
2010-09-21 6:23 ` Florian Mickler
2010-09-21 0:38 ` [RFC PATCH] scripts/get_maintainer.pl: add interactive mode Joe Perches
2010-09-21 5:31 ` Florian Mickler
2010-09-21 6:12 ` Joe Perches
2010-09-21 6:30 ` [PATCH v2] scripts/get_maintainer.pl: fix mailmap handling florian
2010-09-15 15:27 ` [v2 PATCH rfc] scripts/get_maintainer.pl: add interactive mode Joe Perches
2010-09-16 8:30 ` Florian Mickler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285028085.25988.60.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ebiederm@xmission.com \
--cc=florian@mickler.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox