Re: [RFC PATCH 0/2] perf_events: add support for per-cpu per-cgroup monitoring (v3)

Peter Zijlstra
2010-09-25T09:51:53Z

On Wed, 2010-09-22 at 12:26 +0200, Stephane Eranian wrote:

> Ok, early testing shows that this seems to be working fine with the
> pid approach. Of course it is less convenient than just opening a file
> descriptor in cgroup_fs. There is more bookkeeping involved, incl.
> cleanup the child on exit.

Right, so another approach, similar to what you initially proposed,
would be to have this cgroup file, but instead of simply opening and
passing the fd around, have it provide a cgroup id and pass that around
as an integer (or pid_t) in the task argument to the SYSCALL (see the
flag bit below).

You can use the regular lib/idr.c bits to generate ids and maintain an
id->cgroup map.

> The other thing is related to how to indicate we want cgroup and not per-thread.
> For now, my patch is using a new attr.cgroup bit. The alternative is to use a
> bit in the flags parameter to the syscall.

Right, I prefer a bit in the syscall flags argument and somehow using
the task argument.