From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751401Ab0IXRQ1 (ORCPT ); Fri, 24 Sep 2010 13:16:27 -0400 Received: from caiajhbdcaib.dreamhost.com ([208.97.132.81]:43943 "EHLO homiemail-a2.g.dreamhost.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750711Ab0IXRQ0 (ORCPT ); Fri, 24 Sep 2010 13:16:26 -0400 Subject: [PATCH] cpufreq: unnecesary double free in pcc_cpufreq_do_osc From: Davidlohr Bueso Reply-To: dave@gnu.org To: davej@redhat.com, cpufreq@vger.kernel.org Cc: LKML Content-Type: text/plain; charset="UTF-8" Date: Fri, 24 Sep 2010 13:16:21 -0400 Message-ID: <1285348581.3031.2.camel@cowboy> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org x86, cpufreq: avoid an unnecessary double free when finished in pcc_cpufreq_do_osc() There is no need to fall through the out_free label thus saving a kfree call. Signed-off-by: Davidlohr Bueso --- arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c b/arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c index 994230d..db7dc35 100644 --- a/arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c +++ b/arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c @@ -379,6 +379,8 @@ static int __init pcc_cpufreq_do_osc(acpi_handle *handle) if (!(supported & 0x1)) return -ENODEV; + return ret; + out_free: kfree(output.pointer); return ret; -- 1.7.0.4