From: Joe Perches <joe@perches.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'devel@driverdev.osuosl.org'" <devel@driverdev.osuosl.org>,
"'virtualization@lists.osdl.org'" <virtualization@lists.osdl.org>,
"'gregkh@suse.de'" <gregkh@suse.de>
Subject: Re: [PATCH 1/1] Rename camel case variables in channel.c (updated again)
Date: Fri, 24 Sep 2010 10:29:48 -0700 [thread overview]
Message-ID: <1285349388.11616.117.camel@Joe-Laptop> (raw)
In-Reply-To: <1FB5E1D5CA062146B38059374562DF7289EDBC9E@TK5EX14MBXC130.redmond.corp.microsoft.com>
On Fri, 2010-09-24 at 16:06 +0000, Haiyang Zhang wrote:
> From: Haiyang Zhang <haiyangz@microsoft.com>
> - set_bit(Channel->MonitorBit,
> - (unsigned long *)&monitorPage->TriggerGroup
> - [Channel->MonitorGroup].Pending);
> + set_bit(channel->MonitorBit,
> + (unsigned long *)&monitorpage->TriggerGroup
> + [channel->MonitorGroup].Pending);
Unrelated to the camelcase conversion, this casting of
a (u32 *) to an (unsigned long *) to set a bit seems
like a bad idea and an error waiting to happen.
Does it really need to be atomic?
Perhaps it'd be better to write something like:
monitorpage->TriggerGroup[channel->MonitorGroup].Pending |=
(1 << channel->MonitorBit);
Maybe like the other 2 uses of set_bit in hv, it
should be set_bit(channel->MonitorBit & 31, ...
next prev parent reply other threads:[~2010-09-24 17:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 22:04 [PATCH 1/1] Rename camel case variables in channel.c (updated) Haiyang Zhang
2010-09-23 22:38 ` Joe Perches
2010-09-24 16:08 ` Haiyang Zhang
2010-09-24 16:06 ` [PATCH 1/1] Rename camel case variables in channel.c (updated again) Haiyang Zhang
2010-09-24 17:29 ` Joe Perches [this message]
2010-09-27 1:19 ` Greg KH
2010-09-27 2:52 ` Haiyang Zhang
2010-09-27 6:10 ` Greg KH
2010-09-27 17:57 ` Haiyang Zhang
2010-09-27 19:32 ` Greg KH
2010-09-27 22:59 ` Haiyang Zhang
2010-09-28 1:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285349388.11616.117.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox