From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: balbir@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
mingo@elte.hu, paulus@samba.org, davem@davemloft.net,
fweisbec@gmail.com, perfmon2-devel@lists.sf.net,
eranian@gmail.com, robert.richter@amd.com, acme@redhat.com,
Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [RFC PATCH 0/2] perf_events: add support for per-cpu per-cgroup monitoring (v3)
Date: Sat, 25 Sep 2010 11:51:27 +0200 [thread overview]
Message-ID: <1285408287.2275.1061.camel@laptop> (raw)
In-Reply-To: <AANLkTinMsY3KcL7v9R_uwSzVcMVYvsnXHMrbG6Z9XeL4@mail.gmail.com>
On Wed, 2010-09-22 at 12:26 +0200, Stephane Eranian wrote:
> Ok, early testing shows that this seems to be working fine with the
> pid approach. Of course it is less convenient than just opening a file
> descriptor in cgroup_fs. There is more bookkeeping involved, incl.
> cleanup the child on exit.
Right, so another approach, similar to what you initially proposed,
would be to have this cgroup file, but instead of simply opening and
passing the fd around, have it provide a cgroup id and pass that around
as an integer (or pid_t) in the task argument to the SYSCALL (see the
flag bit below).
You can use the regular lib/idr.c bits to generate ids and maintain an
id->cgroup map.
> The other thing is related to how to indicate we want cgroup and not per-thread.
> For now, my patch is using a new attr.cgroup bit. The alternative is to use a
> bit in the flags parameter to the syscall.
Right, I prefer a bit in the syscall flags argument and somehow using
the task argument.
next prev parent reply other threads:[~2010-09-25 9:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 13:05 [RFC PATCH 0/2] perf_events: add support for per-cpu per-cgroup monitoring (v3) Stephane Eranian
2010-09-21 9:38 ` Peter Zijlstra
2010-09-21 9:43 ` Peter Zijlstra
2010-09-21 11:48 ` Stephane Eranian
2010-09-21 12:42 ` Peter Zijlstra
2010-09-21 13:38 ` Stephane Eranian
2010-09-21 14:03 ` Peter Zijlstra
2010-09-21 16:17 ` Stephane Eranian
2010-09-21 16:27 ` Peter Zijlstra
2010-09-21 16:33 ` Stephane Eranian
2010-09-22 4:34 ` Balbir Singh
2010-09-22 7:25 ` Peter Zijlstra
2010-09-22 4:23 ` Balbir Singh
2010-09-22 7:27 ` Peter Zijlstra
2010-09-22 9:18 ` Balbir Singh
2010-09-22 10:26 ` Stephane Eranian
2010-09-25 9:51 ` Peter Zijlstra [this message]
2010-09-28 9:23 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285408287.2275.1061.camel@laptop \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox