The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Rahul Ruikar <rahul.ruikar@gmail.com>
To: linux@dominikbrodowski.net, komurojun-mbn@nifty.com,
	w.sang@pengutronix.de, davem@davemloft.net
Cc: linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org,
	Rahul Ruikar <rahul.ruikar@gmail.com>
Subject: [PATCH] pcmcia: pd6729: Fix error path
Date: Sun, 26 Sep 2010 17:00:29 +0530	[thread overview]
Message-ID: <1285500629-6024-1-git-send-email-rahul.ruikar@gmail.com> (raw)

In error return path
call pci_disable_device() which was enabled earlier.

Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
---
 drivers/pcmcia/pd6729.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c
index b8a869a..deef665 100644
--- a/drivers/pcmcia/pd6729.c
+++ b/drivers/pcmcia/pd6729.c
@@ -646,7 +646,7 @@ static int __devinit pd6729_pci_probe(struct pci_dev *dev,
 	if (!pci_resource_start(dev, 0)) {
 		dev_warn(&dev->dev, "refusing to load the driver as the "
 			"io_base is NULL.\n");
-		goto err_out_free_mem;
+		goto err_out_disable;
 	}
 
 	dev_info(&dev->dev, "Cirrus PD6729 PCI to PCMCIA Bridge at 0x%llx "
-- 
1.7.2.3


             reply	other threads:[~2010-09-26 11:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-26 11:30 Rahul Ruikar [this message]
2010-09-26 13:54 ` [PATCH] pcmcia: pd6729: Fix error path Dominik Brodowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285500629-6024-1-git-send-email-rahul.ruikar@gmail.com \
    --to=rahul.ruikar@gmail.com \
    --cc=davem@davemloft.net \
    --cc=komurojun-mbn@nifty.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=linux@dominikbrodowski.net \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox