public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@gnu.org>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Krzysztof Halasa <khc@pm.waw.pl>,
	Tracey Dent <tdent48227@gmail.com>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] Fs: ext4: namei: fixed file of checkpatch/pl warnings and errors
Date: Sun, 26 Sep 2010 14:35:41 -0400	[thread overview]
Message-ID: <1285526141.3047.0.camel@cowboy> (raw)
In-Reply-To: <20100926182338.GM19690@thunk.org>

On Sun, 2010-09-26 at 14:23 -0400, Ted Ts'o wrote:
> On Sun, Sep 26, 2010 at 08:36:34AM +0200, Krzysztof Halasa wrote:
> > 
> > BTW I wouldn't trust checkpatch so blindly. Also keep in mind checkpatch
> > is only a tool and that maintainers have full authority to ignore the
> > problems (or "problems") it spews.
> 
> I'm beginning to think we need to have an entry in the kernel newbie's
> FAQ warning people that the output of various scripts such as
> checkpatch and get_maintainer are not authoratative, and are
> hueristics intended to be supplemented by human intelligence.

It would actually be quite useful to add a warning in kernelnewbies
about this, some people tend to get too carried away :)

Davidlohr
> 
> 	   	       	  	       	  	- TEd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 



  reply	other threads:[~2010-09-26 18:35 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-25 18:31 [PATCH 01/10] Fs: ext4: acl.c: fixed indent issue Tracey Dent
2010-09-25 18:31 ` [PATCH 02/10] Fs: ext4: acl.h: whitespace cleanup Tracey Dent
2010-09-26  6:11   ` Krzysztof Halasa
2010-09-25 18:31 ` [PATCH 03/10] Fs: ext: balloc: fixed a few issues that checkpatch.pl was having Tracey Dent
2010-09-25 18:31 ` [PATCH 04/10] Fs: ext4: block_validity: added space around = sign Tracey Dent
2010-09-25 18:31 ` [PATCH 05/10] Fs: ext4: ext4: cleaned up the file with checkpatch.pl Tracey Dent
2010-09-26  6:23   ` Krzysztof Halasa
2010-09-25 18:31 ` [PATCH 06/10] Fs: ext4: extents: whitespace cleanup Tracey Dent
2010-09-25 18:31 ` [PATCH 07/10] Fs: ext4: file: fixed indent problem Tracey Dent
2010-09-25 18:31 ` [PATCH 08/10] Fs: ext4: ioctl: fixed spacing issue Tracey Dent
2010-09-25 18:32 ` [PATCH 09/10] Fs: ext4: mballoc.c: whitespace cleanup Tracey Dent
2010-09-25 18:32 ` [PATCH 10/10] Fs: ext4: namei: fixed file of checkpatch/pl warnings and errors Tracey Dent
2010-09-26  6:36   ` Krzysztof Halasa
2010-09-26 18:23     ` Ted Ts'o
2010-09-26 18:35       ` Davidlohr Bueso [this message]
2010-09-26 19:17       ` Krzysztof Halasa
2010-09-25 23:36 ` [PATCH 01/10] Fs: ext4: acl.c: fixed indent issue Christoph Hellwig
2010-09-25 23:53   ` T Dent
2010-09-25 23:56     ` Christoph Hellwig
2010-09-26  0:01       ` Ted Ts'o
2010-09-26  0:09         ` Joe Perches
2010-09-26  0:32           ` Ted Ts'o
2010-09-26  0:36             ` Ted Ts'o
2010-09-26  0:50             ` Joe Perches
2010-09-26  0:58               ` Joe Perches
2010-09-26  6:42                 ` Krzysztof Halasa
2010-09-26  6:49                   ` Joe Perches
2010-09-26 11:31                     ` Krzysztof Halasa
2010-09-26  1:04               ` Ted Ts'o
2010-09-26  1:32                 ` Joe Perches
2010-09-26  1:53                   ` Ted Ts'o
2010-09-26  2:03                     ` Joe Perches
2010-09-26  2:10                       ` Ted Ts'o
2010-09-26  2:21                         ` Ted Ts'o
2010-09-26  2:45                           ` Joe Perches
2010-09-26  2:29                         ` Joe Perches
2010-09-26  0:06       ` Joe Perches
2010-09-26 20:06         ` Christoph Hellwig
2010-09-26 22:17           ` Joe Perches
2010-09-25 23:54 ` Ted Ts'o
2010-09-27 13:52   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285526141.3047.0.camel@cowboy \
    --to=dave@gnu.org \
    --cc=khc@pm.waw.pl \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tdent48227@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox