From: Huang Ying <ying.huang@intel.com>
To: Len Brown <lenb@kernel.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
linux-acpi@vger.kernel.org, Huang Ying <ying.huang@intel.com>
Subject: [PATCH -v2 5/5] ACPI, APEI, Fix ERST MOVE_DATA instruction implementation
Date: Wed, 29 Sep 2010 19:53:55 +0800 [thread overview]
Message-ID: <1285761235-4751-6-git-send-email-ying.huang@intel.com> (raw)
In-Reply-To: <1285761235-4751-1-git-send-email-ying.huang@intel.com>
The src_base and dst_base fields in apei_exec_context are physical
address, so they should be ioremaped before being used in ERST
MOVE_DATA instruction.
Reported-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Huang Ying <ying.huang@intel.com>
---
drivers/acpi/apei/erst.c | 23 ++++++++++++++++++++---
1 file changed, 20 insertions(+), 3 deletions(-)
--- a/drivers/acpi/apei/erst.c
+++ b/drivers/acpi/apei/erst.c
@@ -266,13 +266,30 @@ static int erst_exec_move_data(struct ap
{
int rc;
u64 offset;
+ void *src, *dst;
+
+ /* ioremap does not work in interrupt context */
+ if (in_interrupt()) {
+ pr_warning(ERST_PFX
+ "MOVE_DATA can not be used in interrupt context");
+ return -EBUSY;
+ }
rc = __apei_exec_read_register(entry, &offset);
if (rc)
return rc;
- memmove((void *)(unsigned long)ctx->dst_base + offset,
- (void *)(unsigned long)ctx->src_base + offset,
- ctx->var2);
+
+ src = ioremap(ctx->src_base + offset, ctx->var2);
+ if (!src)
+ return -ENOMEM;
+ dst = ioremap(ctx->dst_base + offset, ctx->var2);
+ if (!dst)
+ return -ENOMEM;
+
+ memmove(dst, src, ctx->var2);
+
+ iounmap(src);
+ iounmap(dst);
return 0;
}
next prev parent reply other threads:[~2010-09-29 11:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 11:53 [PATCH -v2 0/5] ACPI, APEI, BUG fixes for 2.6.36 Huang Ying
2010-09-29 11:53 ` [PATCH -v2 1/5] ACPI, APEI, Fix APEI related table size checking Huang Ying
2010-09-29 15:47 ` Yinghai Lu
2010-09-30 0:11 ` Huang Ying
2010-09-29 18:01 ` Len Brown
2010-09-30 0:25 ` Huang Ying
2010-09-29 18:10 ` Len Brown
2010-09-29 11:53 ` [PATCH -v2 2/5] ACPI, APEI, Fix acpi_pre_map() return value Huang Ying
2010-09-29 18:11 ` Len Brown
2010-09-29 11:53 ` [PATCH -v2 3/5] ACPI, APEI, HEST Fix the unsuitable usage of platform_data Huang Ying
2010-09-29 18:11 ` Len Brown
2010-09-29 11:53 ` [PATCH -v2 4/5] ACPI, APEI, Fix error path for memory allocation Huang Ying
2010-09-29 18:11 ` Len Brown
2010-09-29 11:53 ` Huang Ying [this message]
2010-09-29 18:12 ` [PATCH -v2 5/5] ACPI, APEI, Fix ERST MOVE_DATA instruction implementation Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285761235-4751-6-git-send-email-ying.huang@intel.com \
--to=ying.huang@intel.com \
--cc=andi@firstfloor.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox