From: Namhyung Kim <namhyung@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Roland McGrath <roland@redhat.com>,
Oleg Nesterov <oleg@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH RESEND v3 00/24] ptrace cleanups
Date: Thu, 30 Sep 2010 18:27:35 +0900 [thread overview]
Message-ID: <1285838880-4977-1-git-send-email-namhyung@gmail.com> (raw)
Hello,
This patchset tries to cleanup architecture independent/dependent part of
ptrace syscall. Specifically it changes prototype of sys_ptrace() to have
its arguments @addr and @data to be unsigned long. Since user space API of
ptrace() declares them as void pointers, and most of archs consider them
unsigned already in their arch_ptrace(), it would be no harmful to change
them from (signed) long into unsigned long, IMHO.
ptrace() code accesses user area using above arguments frequently, changing
them enables to drop unnecessary __force markup when casting them to __user
pointers because sparse allows it only in case of unsigned long. And some
duplicated/misused castings can be grouped into one place in favor of new
variables to cleanup code further. This was suggested by Arnd Bergmann and
comment from Christoph Hellwig was also helpful.
Although I couldn't test all archs, I hope it will not break anything.
Any comments would be appreciated.
Thanks.
* Changes from v2:
add Acked-by from maintainers
fix some checkpatch warnings
rebased on top of 2.6.36-rc6
* Changes from v1:
combine all arch signature changes into a single patch
retain uses of get/put_user()
rebased on top of 2.6.36-rc3
---
Namhyung Kim (24):
ptrace: change signature of sys_ptrace() and friends
ptrace: cleanup ptrace_request()
ptrace: change signature of arch_ptrace()
ptrace: cleanup arch_ptrace() on x86
ptrace: cleanup arch_ptrace() on ARM
ptrace: cleanup arch_ptrace() on avr32
ptrace: cleanup arch_ptrace() and friends on Blackfin
ptrace: cleanup arch_ptrace() on cris
ptrace: cleanup arch_ptrace() on frv
ptrace: cleanup arch_ptrace() on h8300
ptrace: cleanup arch_ptrace() on m32r
ptrace: cleanup arch_ptrace() on m68k
ptrace: cleanup arch_ptrace() on m68knommu
ptrace: cleanup arch_ptrace() on microblaze
ptrace: cleanup arch_ptrace() on MIPS
ptrace: cleanup arch_ptrace() on mn10300
ptrace: cleanup arch_ptrace() on parisc
ptrace: cleanup arch_ptrace() on powerpc
ptrace: cleanup arch_ptrace() on score
ptrace: cleanup arch_ptrace() on sh
ptrace: cleanup arch_ptrace() on sparc
ptrace: cleanup arch_ptrace() on tile
ptrace: cleanup arch_ptrace() on um
ptrace: cleanup arch_ptrace() on xtensa
arch/alpha/kernel/ptrace.c | 7 ++--
arch/arm/kernel/ptrace.c | 28 ++++++++-------
arch/avr32/kernel/ptrace.c | 11 +++---
arch/blackfin/kernel/ptrace.c | 16 +++++----
arch/cris/arch-v10/kernel/ptrace.c | 20 +++++-----
arch/cris/arch-v32/kernel/ptrace.c | 16 ++++----
arch/frv/kernel/ptrace.c | 32 ++++++++---------
arch/h8300/kernel/ptrace.c | 33 +++++++++---------
arch/ia64/kernel/ptrace.c | 3 +-
arch/m32r/kernel/ptrace.c | 11 +++---
arch/m68k/kernel/ptrace.c | 51 ++++++++++++++-------------
arch/m68knommu/kernel/ptrace.c | 63 ++++++++++++++++------------------
arch/microblaze/kernel/ptrace.c | 5 ++-
arch/mips/kernel/ptrace.c | 25 +++++++------
arch/mn10300/kernel/ptrace.c | 20 +++++-----
arch/parisc/kernel/ptrace.c | 13 ++++---
arch/powerpc/kernel/ptrace.c | 66 ++++++++++++++++++-----------------
arch/s390/kernel/ptrace.c | 3 +-
arch/score/kernel/ptrace.c | 7 ++--
arch/sh/kernel/ptrace_32.c | 45 +++++++++++++-----------
arch/sh/kernel/ptrace_64.c | 25 +++++++++-----
arch/sparc/kernel/ptrace_32.c | 57 ++++++++++++-------------------
arch/sparc/kernel/ptrace_64.c | 15 ++++----
arch/tile/kernel/ptrace.c | 11 +++---
arch/um/kernel/ptrace.c | 23 ++++++------
arch/um/sys-i386/ptrace.c | 4 +-
arch/um/sys-x86_64/ptrace.c | 11 +++---
arch/x86/kernel/ptrace.c | 20 +++++------
arch/xtensa/kernel/ptrace.c | 14 ++++---
include/linux/ptrace.h | 12 ++++--
include/linux/syscalls.h | 3 +-
kernel/ptrace.c | 30 +++++++++-------
32 files changed, 360 insertions(+), 340 deletions(-)
--
1.7.2.2
next reply other threads:[~2010-09-30 9:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 9:27 Namhyung Kim [this message]
2010-09-30 9:27 ` [PATCH RESEND v3 01/24] ptrace: change signature of sys_ptrace() and friends Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 02/24] ptrace: cleanup ptrace_request() Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 03/24] ptrace: change signature of arch_ptrace() Namhyung Kim
2010-09-30 18:58 ` David Miller
2010-10-04 19:21 ` Geert Uytterhoeven
2010-09-30 9:27 ` [PATCH RESEND v3 04/24] ptrace: cleanup arch_ptrace() on x86 Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 05/24] ptrace: cleanup arch_ptrace() on ARM Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 06/24] ptrace: cleanup arch_ptrace() on avr32 Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 07/24] ptrace: cleanup arch_ptrace() and friends on Blackfin Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 08/24] ptrace: cleanup arch_ptrace() on cris Namhyung Kim
2010-09-30 10:36 ` Mikael Starvik
2010-09-30 9:27 ` [PATCH RESEND v3 09/24] ptrace: cleanup arch_ptrace() on frv Namhyung Kim
2010-10-02 3:18 ` Daniel K.
2010-10-02 3:57 ` Namhyung Kim
2010-10-02 4:59 ` Namhyung Kim
2010-10-02 6:13 ` Daniel K.
2010-09-30 9:27 ` [PATCH RESEND v3 10/24] ptrace: cleanup arch_ptrace() on h8300 Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 11/24] ptrace: cleanup arch_ptrace() on m32r Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 12/24] ptrace: cleanup arch_ptrace() on m68k Namhyung Kim
2010-10-04 19:22 ` Geert Uytterhoeven
2010-09-30 9:27 ` [PATCH RESEND v3 13/24] ptrace: cleanup arch_ptrace() on m68knommu Namhyung Kim
2010-10-04 23:42 ` Andrew Morton
2010-10-05 3:49 ` [PATCH UPDATED] " Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 14/24] ptrace: cleanup arch_ptrace() on microblaze Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 15/24] ptrace: cleanup arch_ptrace() on MIPS Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 16/24] ptrace: cleanup arch_ptrace() on mn10300 Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 17/24] ptrace: cleanup arch_ptrace() on parisc Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 18/24] ptrace: cleanup arch_ptrace() on powerpc Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 19/24] ptrace: cleanup arch_ptrace() on score Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 20/24] ptrace: cleanup arch_ptrace() on sh Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 21/24] ptrace: cleanup arch_ptrace() on sparc Namhyung Kim
2010-09-30 19:00 ` David Miller
2010-09-30 9:27 ` [PATCH RESEND v3 22/24] ptrace: cleanup arch_ptrace() on tile Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 23/24] ptrace: cleanup arch_ptrace() on um Namhyung Kim
2010-09-30 9:27 ` [PATCH RESEND v3 24/24] ptrace: cleanup arch_ptrace() on xtensa Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285838880-4977-1-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox