From: Davidlohr Bueso <dave@gnu.org>
To: davej@redhat.com, cpufreq@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [RESEND PATCH] cpufreq: unnecesary double free in pcc_cpufreq_do_osc
Date: Thu, 30 Sep 2010 15:43:24 -0400 [thread overview]
Message-ID: <1285875804.2180.1.camel@cowboy> (raw)
x86, cpufreq: avoid an unnecessary double free when finished in pcc_cpufreq_do_osc()
There is no need to fall through the out_free label thus saving a kfree call.
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c b/arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c
index 994230d..db7dc35 100644
--- a/arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c
+++ b/arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c
@@ -379,6 +379,8 @@ static int __init pcc_cpufreq_do_osc(acpi_handle *handle)
if (!(supported & 0x1))
return -ENODEV;
+ return ret;
+
out_free:
kfree(output.pointer);
return ret;
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
next reply other threads:[~2010-09-30 19:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 19:43 Davidlohr Bueso [this message]
2010-09-30 19:59 ` [RESEND PATCH] cpufreq: unnecesary double free in pcc_cpufreq_do_osc Pekka Enberg
2010-09-30 20:06 ` Dave Jones
2010-10-01 4:47 ` Pekka Enberg
2010-10-01 5:25 ` Dave Jones
2010-09-30 20:06 ` David Rientjes
2010-09-30 20:02 ` David Rientjes
2010-09-30 20:08 ` Dave Jones
2010-09-30 20:17 ` Davidlohr Bueso
2010-09-30 20:15 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285875804.2180.1.camel@cowboy \
--to=dave@gnu.org \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox