From: "Marc - A. Dahlhaus" <mad@wol.de>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, isdn@linux-pingi.de
Subject: [PATCH] Fix capi devicenames v2
Date: Fri, 01 Oct 2010 10:02:53 +0200 [thread overview]
Message-ID: <1285920173.13411.34.camel@marc> (raw)
In-Reply-To: <AANLkTimRa9VsOgSkcdrg=41pskEbMhNL4D9SXeV3dztG@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]
Specification in devices.txt about capi devices is out of date as the capifs
layout for capi tty devices was never added to it.
Recent udev versions can't produce working device nodes because of a typo in
the device_create call for the capi control device.
Due to this the wrong node name of the control device "capi" collides with
the "capi" directory under which the now deprecated capifs was mounted and
created the capi tty device nodes.
This also changes the capi tty device names passed to udev to the capifs
layout which isn't mentioned in the specs.
Signed-off-by: Marc - Andre Dahlhaus <mad@wol.de>
--- a/drivers/isdn/capi/capi.c
+++ b/drivers/isdn/capi/capi.c
@@ -1363,7 +1363,7 @@ static int __init capinc_tty_init(void)
}
drv->owner = THIS_MODULE;
drv->driver_name = "capi_nc";
- drv->name = "capi";
+ drv->name = "capi/";
drv->major = 0;
drv->minor_start = 0;
drv->type = TTY_DRIVER_TYPE_SERIAL;
@@ -1509,7 +1509,7 @@ static int __init capi_init(void)
return PTR_ERR(capi_class);
}
- device_create(capi_class, NULL, MKDEV(capi_major, 0), NULL, "capi");
+ device_create(capi_class, NULL, MKDEV(capi_major, 0), NULL, "capi20");
if (capinc_tty_init() < 0) {
device_destroy(capi_class, MKDEV(capi_major, 0));
[-- Attachment #2: capi-name.patch --]
[-- Type: text/x-patch, Size: 1249 bytes --]
Specification in devices.txt about capi devices is out of date as the capifs
layout for capi tty devices was never added to it.
Recent udev versions can't produce working device nodes because of a typo in
the device_create call for the capi control device.
Due to this the wrong node name of the control device "capi" collides with
the "capi" directory under which the now deprecated capifs was mounted and
created the capi tty device nodes.
This also changes the capi tty device names passed to udev to the capifs
layout which isn't mentioned in the specs.
Signed-off-by: Marc - Andre Dahlhaus <mad@wol.de>
--- a/drivers/isdn/capi/capi.c
+++ b/drivers/isdn/capi/capi.c
@@ -1363,7 +1363,7 @@ static int __init capinc_tty_init(void)
}
drv->owner = THIS_MODULE;
drv->driver_name = "capi_nc";
- drv->name = "capi";
+ drv->name = "capi/";
drv->major = 0;
drv->minor_start = 0;
drv->type = TTY_DRIVER_TYPE_SERIAL;
@@ -1509,7 +1509,7 @@ static int __init capi_init(void)
return PTR_ERR(capi_class);
}
- device_create(capi_class, NULL, MKDEV(capi_major, 0), NULL, "capi");
+ device_create(capi_class, NULL, MKDEV(capi_major, 0), NULL, "capi20");
if (capinc_tty_init() < 0) {
device_destroy(capi_class, MKDEV(capi_major, 0));
next prev parent reply other threads:[~2010-10-01 8:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 19:21 [PATCH] Fix capi devicenames Marc - A. Dahlhaus
2010-09-30 9:30 ` Alan Cox
2010-09-30 10:08 ` Kay Sievers
2010-09-30 10:56 ` Alan Cox
2010-09-30 10:37 ` Marc - A. Dahlhaus
2010-09-30 10:50 ` Kay Sievers
2010-09-30 11:29 ` Alan Cox
2010-09-30 12:50 ` Marc - A. Dahlhaus
2010-09-30 17:35 ` Olivier Galibert
2010-09-30 19:20 ` Kay Sievers
2010-10-01 8:02 ` Marc - A. Dahlhaus [this message]
2010-10-01 8:36 ` Marc - A. Dahlhaus
2010-10-01 9:20 ` Kay Sievers
2010-09-30 11:35 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285920173.13411.34.camel@marc \
--to=mad@wol.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=isdn@linux-pingi.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox