From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755931Ab0JAUqv (ORCPT ); Fri, 1 Oct 2010 16:46:51 -0400 Received: from gate.crashing.org ([63.228.1.57]:48842 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753830Ab0JAUqt (ORCPT ); Fri, 1 Oct 2010 16:46:49 -0400 Subject: Re: [patch 46/47] powerpc: Use new irq allocator From: Benjamin Herrenschmidt To: Thomas Gleixner Cc: LKML , linux-arch@vger.kernel.org, Linus Torvalds , Andrew Morton , x86@kernel.org, Peter Zijlstra , Paul Mundt , Russell King , David Woodhouse , Jesse Barnes , Yinghai Lu , Grant Likely , "Eric W. Biederman" In-Reply-To: References: <20100930221351.682772535@linutronix.de> <20100930221743.014571381@linutronix.de> <1285893737.2463.4.camel@pasglop> Content-Type: text/plain; charset="UTF-8" Date: Sat, 02 Oct 2010 06:46:13 +1000 Message-ID: <1285965973.2463.129.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2010-10-01 at 15:07 +0200, Thomas Gleixner wrote: > On Fri, 1 Oct 2010, Benjamin Herrenschmidt wrote: > > > On Thu, 2010-09-30 at 23:18 +0000, Thomas Gleixner wrote: > > > plain text document attachment (powerpc-use-new-allocator.patch) > > > Use the new functions and free the descriptor when the virq is > > > destroyed. > > > > Looks ok as a first pass, but we should go further and replace the > > allocator we have in powerpc to use yours instead. > > > > Then I should get rid of my big irq_map that maps virq to HW number & > > domain pointers and instead put those in the irq data. Any objection to > > me sticking some archdata there for that purpose ? > > No, though if we can avoid another void pointer and have a sensible > data structure for it would be nice. Yes, I'm thinking about an arch defined structure like I did for struct device. Cheers, Ben. > > That would make things much cleaner and in fact move one large step > > toward being able to make powerpc virq scheme generic, which seems to be > > a good idea from what I've heard :-) > > Yep. > > Thanks, > > tglx > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/