From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Haojian Zhuang <haojian.zhuang@marvell.com>
Subject: Re: [PATCH] regulator: max8649 - fix setting extclk_freq
Date: Sat, 02 Oct 2010 14:22:33 +0100 [thread overview]
Message-ID: <1286025753.3125.25.camel@odin> (raw)
In-Reply-To: <20101001173643.GB21157@opensource.wolfsonmicro.com>
On Fri, 2010-10-01 at 10:36 -0700, Mark Brown wrote:
> On Fri, Oct 01, 2010 at 07:18:14PM +0800, Axel Lin wrote:
> > 2010/10/1 Mark Brown <broonie@opensource.wolfsonmicro.com>:
>
> > > Are there existing users of the driver? It's not always 100% clear if
> > > people are expecting bitfield values that will be shifted in or values
> > > that can be ored directly in. I don't really mind either way but I'd
> > > rather be careful.
>
> > I think I should explain this way:
>
> > In max8649.h , we have
> > enum {
> > MAX8649_EXTCLK_26MHZ = 0,
> > MAX8649_EXTCLK_13MHZ,
> > MAX8649_EXTCLK_19MHZ, /* 19.2MHz */
> > };
>
> OK, that's clearer. When changing the interpretation of existing
> platform data like this it's good to note this sort of thing in the
> changelog since merge issues can be a real pain.
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> --
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-10-02 13:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 5:56 [PATCH] regulator: max8649 - fix setting extclk_freq Axel Lin
2010-10-01 7:19 ` Mark Brown
2010-10-01 7:53 ` Axel Lin
2010-10-01 11:18 ` Axel Lin
2010-10-01 17:36 ` Mark Brown
2010-10-02 13:22 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286025753.3125.25.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=haojian.zhuang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox