From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Daniel Drake <dsd@laptop.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] serial8250: ratelimit "too much work" error
Date: Mon, 04 Oct 2010 15:59:29 -0700 [thread overview]
Message-ID: <1286233169.10512.85.camel@Joe-Laptop> (raw)
In-Reply-To: <20101004152102.1e04f30a.akpm@linux-foundation.org>
On Mon, 2010-10-04 at 15:21 -0700, Andrew Morton wrote:
> On Mon, 04 Oct 2010 15:10:59 -0700
> Joe Perches <joe@perches.com> wrote:
> > On Mon, 2010-10-04 at 15:02 -0700, Andrew Morton wrote:
> > > On Mon, 4 Oct 2010 14:51:01 -0700
> > > Andrew Morton <akpm@linux-foundation.org> wrote:
> > > I'll give up and pronounce that users of printk_ratelimited() need to
> > > include ratelimit.h as well.
> > What I suggested several months ago was to move the
> > macro definitions to ratelimit.h
> > http://lkml.org/lkml/2010/2/18/377
> That's a bit nasty because at present ratelimit.h is purely about
> ratelimiting and knowns nothing about any of its clients. At present
> it has only one client (printk), but it could have more in the future!
Look at the structure, it's very specific to
message logging functionality.
struct ratelimit_state {
spinlock_t lock; /* protect the state */
int interval;
int burst;
int printed;
int missed;
unsigned long begin;
};
I think it's likely that the current ratelimit
will not be used for any other function.
next prev parent reply other threads:[~2010-10-04 22:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 11:04 [PATCH] serial8250: ratelimit "too much work" error Daniel Drake
2010-10-02 14:22 ` Alan Cox
2010-10-04 21:51 ` Andrew Morton
2010-10-04 22:02 ` Andrew Morton
2010-10-04 22:10 ` Joe Perches
2010-10-04 22:21 ` Andrew Morton
2010-10-04 22:59 ` Joe Perches [this message]
2010-10-04 23:11 ` Andrew Morton
2010-10-04 23:34 ` Joe Perches
2010-10-04 23:49 ` Andrew Morton
2010-10-05 0:26 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286233169.10512.85.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dsd@laptop.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox