Re: [PATCH 1/2] drivers:bluetooth: TI_ST bluetooth driver

Gustavo F. Padovan
2010-10-07T20:51:36Z

Hi Greg,

* Greg KH <greg@kroah.com> [2010-10-07 07:34:09 -0700]:

> On Thu, Oct 07, 2010 at 12:05:48PM +0200, Marcel Holtmann wrote:
> > Hi Pavan,
> >
> > > This is the bluetooth protocol driver for the TI WiLink7 chipsets.
> > > Texas Instrument's WiLink chipsets combine wireless technologies
> > > like BT, FM, GPS and WLAN onto a single chip.
> > >
> > > This Bluetooth driver works on top of the TI_ST shared transport
> > > line discipline driver which also allows other drivers like
> > > FM V4L2 and GPS character driver to make use of the same UART interface.
> > >
> > > Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
> > > ---
> > > drivers/bluetooth/bt_ti.c | 463 ++++++++++++++++++++++++++++++++++++
> > > drivers/staging/ti-st/bt_drv.c | 509 ----------------------------------------
> > > drivers/staging/ti-st/bt_drv.h | 61 -----
> > > 3 files changed, 463 insertions(+), 570 deletions(-)
> > > create mode 100644 drivers/bluetooth/bt_ti.c
> > > delete mode 100644 drivers/staging/ti-st/bt_drv.c
> > > delete mode 100644 drivers/staging/ti-st/bt_drv.h
> >
> > I don't care about staging at all. So you sort that out with Greg.
> >
> > Submit your driver for upstream inclusion. And once accepted you can pin
> > Greg about removing it.
>
> The driver is already in staging, this is the request to move it out of
> staging and into the "correct" place in the tree. The core of the ti-st
> code is now in the drivers/misc/ directory in the linux-next tree, and
> this patch is the request to move the bluetooth drive into the proper
> drivers/bluetooth/ location.

I'm wondering why this driver never touched linux-bluetooth before. It
is on staging because it is not ready for a proper merge and while it is
not ready it needs the comments from the bluetooth developers here to
get it ready for merge in drivers/bluetooth. So why this never arrived
here before?

--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi