From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756028Ab0JHIhw (ORCPT ); Fri, 8 Oct 2010 04:37:52 -0400 Received: from senator.holtmann.net ([87.106.208.187]:54997 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752360Ab0JHIhu (ORCPT ); Fri, 8 Oct 2010 04:37:50 -0400 Subject: Re: [PATCH 1/2] drivers:bluetooth: TI_ST bluetooth driver From: Marcel Holtmann To: "Gustavo F. Padovan" Cc: pavan_savoy@ti.com, linux-bluetooth@vger.kernel.org, greg@kroah.com, linux-kernel@vger.kernel.org In-Reply-To: <20101007184534.GB13602@vigoh> References: <1286477237-7526-1-git-send-email-pavan_savoy@ti.com> <1286477237-7526-2-git-send-email-pavan_savoy@ti.com> <20101007184534.GB13602@vigoh> Content-Type: text/plain; charset="UTF-8" Date: Fri, 08 Oct 2010 10:37:42 +0200 Message-ID: <1286527062.6145.182.camel@aeonflux> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 (2.30.3-1.fc13) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gustavo, > Change the commit subject to "Bluetooth: TI_ST bluetooth driver" > > * pavan_savoy@ti.com [2010-10-07 14:47:16 -0400]: > > > From: Pavan Savoy > > > > This is the bluetooth protocol driver for the TI WiLink7 chipsets. > > Texas Instrument's WiLink chipsets combine wireless technologies > > like BT, FM, GPS and WLAN onto a single chip. > > > > This Bluetooth driver works on top of the TI_ST shared transport > > line discipline driver which also allows other drivers like > > FM V4L2 and GPS character driver to make use of the same UART interface. > > > > Signed-off-by: Pavan Savoy > > --- > > drivers/bluetooth/bt_ti.c | 489 +++++++++++++++++++++++++++++++++++++++++++++ > > 1 files changed, 489 insertions(+), 0 deletions(-) > > create mode 100644 drivers/bluetooth/bt_ti.c > > We don't have filename with bt_.. in drivers/bluetooth/. Maybe ti_st.c > should be a better name, or something like that. actually we have the bt prefix for company generic ones where they didn't wanna use the hardware name. So I prefer to use the hardware for a driver since it is much more clear that way. You acronym naming here is bad. It is confusing like hell. What about just calling this btwilink.c or something. I just spinning ideas here. Regards Marcel